Bug 129435

Summary:	EDITING Insert - Field - doesn't work with UI Tabbed compact
Product:	LibreOffice	Reporter:	Stefan_Lange_KA <Stefan_Lange_KA>
Component:	Calc	Assignee:	Xisco Faulí <xiscofauli>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kainz.a, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.0.0.0.alpha0+
Hardware:	All
OS:	All
Whiteboard:	target:6.5.0 target:6.4.0.1
Crash report or crash signature:		Regression By:

Description Stefan_Lange_KA@T-Online.de 2019-12-16 20:59:01 UTC

When in Calc the User Interface "Tabbed compact" is activated, in the Tab "Insert" a click on the arrow belonging to "Field" is without any effect.
Other arrows do work properly (Symbol, Formula, Emoji, Basic Shapes, ...) and the problem also doesn't occur with UI "Tabbed".

In all builds of LO 6.5.0.0 installed from https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2019-12-05_04.54.44/ or earlier the problem doesn't occur.

The problem first occurs with the build installed from https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2019-12-06_04.46.39/ and it still exists with build installed from https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2019-12-16_04.51.40/.

Reproducing the problem:
- install LO 6.5.0.0 from https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2019-12-06_04.46.39/ or newer
- New -> spreadsheet document
- change user interface to "Tabbed compact"
- select any cell
- select tab "Insert" and click on the arrow belonging to "Field" --> nothing happens
- correct would be if a menu appears with the items "Date" and "Time"

Comment 1 Xisco Faulí 2019-12-17 15:10:59 UTC

Reproduced in

Version: 6.5.0.0.alpha0+
Build ID: f86824cca0c442d371379d2ea0bff2241f18ab3d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Comment 2 Xisco Faulí 2019-12-17 15:20:28 UTC

Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=81f01259dfe29b7ee73c42d3b44934d6fc973cd8

author	andreas kainz <kainz.a@gmail.com>	2019-12-04 22:07:36 +0100
committer	andreas_kainz <kainz.a@gmail.com>	2019-12-05 12:18:55 +0100
commit 81f01259dfe29b7ee73c42d3b44934d6fc973cd8 (patch)
tree af31e876ad9ea99d76e2e987f898d23e3f471047
parent e3795de3c10d81f752826a406cea9fe090e4538e (diff)
tdf#101513 arrangement of customizeable items in NB tabbed compact

Bisected with: bibisect-linux64-6.5

Adding Cc: to andreas kainz

Comment 3 Xisco Faulí 2019-12-17 15:27:44 UTC

patch in gerrit: https://gerrit.libreoffice.org/#/c/85306/

Comment 4 Commit Notification 2019-12-17 16:31:07 UTC

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb6d402ed7d0e5a32783d33da9cace1a9812031a

tdf#129435: Fix menu reference

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 5 Commit Notification 2019-12-17 16:31:23 UTC

Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/4d011333eb8fb1af7609a928212c8febcf50a4e3

tdf#129435: Fix menu reference

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 Stefan_Lange_KA@T-Online.de 2019-12-18 06:38:23 UTC

Test was succesful with
Version: 6.5.0.0.alpha0+ (x64)
Build-ID: 491e8f60bf7f216a3bb3092b22334924b6c9aee1
CPU-Threads: 4; BS: Windows 10.0 Build 19536; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

Many thanks for the correction!