| Summary: | KeyID gogLP is assigned to two strings | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | So <sou> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aron.budea, caolan.mcnamara, ming.v.hua, serval2412, sophi, xiscofauli |
| Priority: | medium | ||
| Version: | 6.4.0.0.beta1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.1.0 target:7.0.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
So
2019-12-21 09:12:49 UTC
https://weblate.documentfoundation.org/translate/libo_ui-master/svtoolsmessages/ja/?checksum=ae66d01f89ea8fc https://weblate.documentfoundation.org/translate/libo_ui-master/svxmessages/ja/?checksum=ae66d01f89ea8fc I can only confirm the bug. Now I don't know how key ids are generated. So as I understand the clash is between these two: <property name="label" translatable="yes" context="colorwindow|none_color_button">None</property> https://opengrok.libreoffice.org/xref/core/svtools/uiconfig/ui/linewindow.ui?r=8e2bd8fb#17 <property name="label" translatable="yes" context="colorwindow|none_color_button">None</property> https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/colorwindow.ui?r=6e6fdb62#57 Caolán, would changing the context from colorwindow to linewindow solve this clash? (In reply to Aron Budea from comment #3) > ... > Caolán, would changing the context from colorwindow to linewindow solve this > clash? Caolán will know better than me but IMHO I think you're right so you should submit a patch. I imagine comment #3 is the right thing to do. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/486c946aa0e489580b78b2934259fe24696057c0 tdf#129537 duplicate context in two different modules It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/ff4fe7e9183ed3811a4674c95c58fa8690f360dc tdf#129537 duplicate context in two different modules It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I don't know if we should fix it in 6-4 seeing as presumably that disrupts existing translations and I presume its not significant enough to require doing that. (In reply to Caolán McNamara from comment #8) > I don't know if we should fix it in 6-4 seeing as presumably that disrupts > existing translations and I presume its not significant enough to require > doing that. Agreed, no need to have it in 6-4 and thanks for fixing it. (In reply to Commit Notification from comment #6) > Caolán McNamara committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/486c946aa0e489580b78b2934259fe24696057c0 > > tdf#129537 duplicate context in two different modules > > It will be available in 7.1.0. - <property name="label" translatable="yes" context="colorwindow|none_color_button">None</property> + <property name="label" translatable="yes" context="linewindow|none_color_button">None</property> In the spirit of providing correct context for translators, instead of just avoiding KeyID clash, shouldn't the context be "linewindow|none_line_button"? we can do that Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d15e6808a217aea9ac7c56e0c4c8ef2dc58ec94 tdf#129537 call it none_line_button not none_color_button It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/09b70f8d846d718b73eaaf80c368a8a5cc9f9596 tdf#129537 call it none_line_button not none_color_button It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |