| Summary: | Keyboard navigation not working when focus is in a toolbar item with a sub control (GTK3) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Jim Raykowski <raykowj> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, lo_bugs, vsfoote, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:6.5.0 target:7.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | bug demonstration | ||
|
Description
Jim Raykowski
2019-12-26 18:26:55 UTC
@Mike, I've been seeing this in Windows builds on the Notebook Bar, the tab/cursor "key traps" passing into the listbox widgets, in bug 109425--related? s/@Mike/@Jim -- sorry Jim, working on my first cup of coffee - Stuart Reproduced in Version: 6.5.0.0.alpha0+ Build ID: 1abfc8e2f677024ea058e96f3133e503ba89ea02 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Adding Cc: to Caolán McNamara https://gerrit.libreoffice.org/c/core/+/86262 makes this work for me Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f1604675e71c67024887d12bf73ccb86ac05a7a3 tdf#129634 send SalEvent::LoseFocus only if some other widget gains focus It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. FWIW re comment #1, bug #109425 must be something different as this is gtk3 only *** Bug 129657 has been marked as a duplicate of this bug. *** *** Bug 129776 has been marked as a duplicate of this bug. *** In a local build of commit 92ccf53b, running under xfce, configured
CCFLAGS=-Wshadow
--with-jdk-home=/usr/lib/jvm/default-java
--enable-split-debug
--enable-gdb-index
--enable-ld=gold
--enable-option-checking=fatal
--enable-dbgutil
--enable-debug
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
--without-package-format
and built and running on debian-buster, I still see the problem. I am
setting bug status REOPENED.
The issue is fixed for me Version: 6.5.0.0.alpha0+ Build ID: bf540873f5e258452fed5006f65a403c95e7872a CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Terrence Enger, Could you please paste the info from Help - about LibreOffice ? I confirm bug is gone when toolbar is docked. Unexpected behavior still present when toolbar is undocked. Version: 6.5.0.0.alpha0+ Build ID: ecb5130e16898c0d2485e99564c57882b5ef25b0 CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Whoops! I am confused. My comment 9 should have been applied to bug 129776. My change of status to REOPENED was wrong, but I am leaving it, in view of Jim Raykowski's comment 11. how about now after... https://cgit.freedesktop.org/libreoffice/core/commit/?id=b7411079bb833aa2857aa4b0de7cd4eeb6dc06fa vcl: ignore floating window set-focus events because they generate unwanted lose focus events in their parent. We only want these set-focus events for native widgets hosted in the sidebar. does that make a difference ? Created attachment 157624 [details]
bug demonstration
Still repro with gtk3
[Automated Action] NeedInfo-To-Unconfirmed Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/02c5a61944a212ecc4573001a2fb853339448b03 tdf#129634 ignore floating toolbars It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I confirm the most recent patch fixes the keyboard navigation issue. Thanks Caolán! oh good |