Bug 130199

Summary:	Confirm deletion of hidden sections
Product:	LibreOffice	Reporter:	Roman Kuznetsov <79045_79045>
Component:	Writer	Assignee:	Balázs Varga (allotropia) <balazs.varga991>
Status:	VERIFIED FIXED
Severity:	enhancement	CC:	79045_79045, dgp-mail, heiko.tietze, vsfoote
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=128843
Whiteboard:	target:7.6.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	107738
Attachments:	Example file with two hidden sections

Description Roman Kuznetsov 2020-01-25 20:33:50 UTC

Description:
Add some indicator for mark place of hidden section in document like comment or something

Steps to Reproduce:
1. Open Writer
2. Create a section (Insert-Section)
3. Enter some text into your section
4. Hide your section
5. Now you didn't place in text where your section is and you can VERY EASY delete it as empty paragraph is you forgot where it is.
6. Suggest mark place with hidden section somehow (like comment or may be some float icon). Also may be need add warning message when you try delete hidden section?

Actual Results:
if you hidden a section then you don't see it at all its place into text. There are no any indicators

Expected Results:
you can easy find all hidden section in your document because will be some indicators for it


Reproducible: Always


User Profile Reset: No



Additional Info:
-

Comment 1 V Stuart Foote 2020-01-26 04:55:05 UTC

The hidden section shows in the Navigator, and a click on the section, or  navigate by 'Section' will position to start of the hidden section. Isn't that enough?

Comment 2 Dieter 2020-01-26 06:22:57 UTC

(In reply to V Stuart Foote from comment #1)
> Isn't
> that enough?

I would say it is enough to find a hidden section, but not enough to prevent from unwanted delete. So I would narrow down this enhancement to a warning message, when you try to delete a hidden section. Comment would only help, if comments are displayed in your actual view.

Comment 3 Heiko Tietze 2020-01-27 10:47:20 UTC

Agree with Dieter to enhance the existing discoverability via Navigator by a confirmation box when a hidden section is to be deleted.

Comment 4 ibelin123 2021-02-06 03:41:54 UTC

+1 For both the indicator and a warning when you delete a hidden section.


(In reply to V Stuart Foote from comment #1)
> The hidden section shows in the Navigator, and a click on the section, or 
> navigate by 'Section' will position to start of the hidden section. Isn't
> that enough?

It is not enough for me because I would have to go a navigator and click section to find it. 

It would be great to just look at a "part" of a document and see that a section is hidden in that part.

Comment 5 Gabor Kelemen (allotropia) 2023-04-12 06:34:45 UTC

Created attachment 186597 [details]
Example file with two hidden sections

Second one is also password protected with: aaaaa

Comment 6 Commit Notification 2023-04-17 21:33:55 UTC

Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6feafa2c5a2c593b1852ac44e2ea88eb9375c01d

tdf#130199 sw Confirm deletion of hidden sections

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 7 Roman Kuznetsov 2023-04-18 13:34:44 UTC

Verified (there is a warning message now) in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0ee9501c0b7dc1a291715fff9c1934b1c08cb654
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

but I still would prefer to have some visual indicator for hidden section...