| Summary: | QR-Code Generator crashes when text too long | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | jochen.sollermann |
| Component: | LibreOffice | Assignee: | shubhamgoyal <22shubh22> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 22shubh22, ming.v.hua, placekjem, serval2412 |
| Priority: | medium | Keywords: | haveBacktrace |
| Version: | 6.4.0.3 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| Whiteboard: | target:7.0.0 target:7.1.0 target:7.0.0.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | bt with debug symbols | ||
|
Description
jochen.sollermann
2020-01-30 00:55:39 UTC
Created attachment 157522 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
I put "catch throw" just before the test and got this bt.
Shubham: one for you? I will take this one *** Bug 130781 has been marked as a duplicate of this bug. *** Shubham: any update here? Julien, The exception handling should be done at the Library level or at the LibreOffice level? (In reply to shubhamgoyal from comment #6) > Julien, > The exception handling should be done at the Library level or at the > LibreOffice level? No idea. I think you should ask on LO dev forum or directly on IRC on dev channel. okay 22shubh22 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/93fe47e113628925b3caf33502326c7b136263a1 tdf#130272 A warning is now shown and LO do not crash It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #9) > 22shubh22 committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > 93fe47e113628925b3caf33502326c7b136263a1 > > tdf#130272 A warning is now shown and LO do not crash Although I'm not a native speaker, I feel the error message in this patch > "RID_SVXSTR_QRCODEDATALONG", "Text exceeds the maximum bits for Error Correction, Enter shorter text" has some room for improvement. "Bits" feels too technical for ordinary users, and suggestion of using lower level of error correction should be given in additional to shortening the text. I would propose something like "URL/Text is too long for the current Error Correction level, please enter shorter text or decrease Error Correction." Or should I move these comments to a new bug report? Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3c0511b6b6cfda1fdb675fe9cfbb7199860cf522 Related: tdf#130272 Improve English in error message It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/dd046d74f25bd056f2d62cfce4f749cb74a7c903 Related: tdf#130272 Improve English in error message It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |