Bug 130839

Summary: There is extra margin on second level in SmartArt
Product: LibreOffice Reporter: Gülşah Köse <gulsah.kose>
Component: ImpressAssignee: Gülşah Köse <gulsah.kose>
Status: RESOLVED FIXED    
Severity: normal CC: gerald
Priority: medium    
Version: 7.0.0.0.alpha0+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=130776
Whiteboard: target:7.0.0 target:6.4.2 target:6.3.6
Crash report or crash signature: Regression By:
Bug Depends on: 130776    
Bug Blocks:    
Attachments: Sample file
Sample compared MSO 2013 LO 7.0+
Sample file resaved in MSO 2013

Description Gülşah Köse 2020-02-21 13:32:55 UTC
Description:
When we open the sample file in LibreOffice we can see the SmartArt second level left margin is bigger than in MSO2010.

Steps to Reproduce:
1.Open sample.pptx with LO
2. Open sample.pptx wit MSO

Actual Results:
LO shows more left margin than MSO

Expected Results:
Left margins should be same.


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Gülşah Köse 2020-02-21 13:33:34 UTC
Created attachment 158076 [details]
Sample file
Comment 2 Commit Notification 2020-02-24 06:34:52 UTC
Gülşah Köse committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eeaa7aba6e7ace8b69d7056645b15be2f996d8fb

tdf130839: Corrects second level left margin in Smartart

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2020-02-24 07:24:47 UTC
Gülşah Köse committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/73cac1031131021819a0fbd4d60554196aea230c

tdf130839: Corrects second level left margin in Smartart

It will be available in 6.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-02-24 07:49:36 UTC
Gülşah Köse committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/3c10f574cd342bfdb6b11ea9bb89849c978dab5e

tdf130839: Corrects second level left margin in Smartart

It will be available in 6.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Timur 2020-03-31 09:30:23 UTC
Created attachment 159178 [details]
Sample compared MSO 2013 LO 7.0+

I wanted to verify, but I couldn't.
PPTX seems to be created in MSO 2013 ? but it gives warning in LO that it should be resaved in MSO 2010 or later. 
This PPTX is empty for older LO and same for LO 6.2 and 7.0+. That's known limitation of LO in opening older PPTX with SmartArt, there are other bugs on that (searchable with "SmartArt" and "2007").
If PPTX is resaved in MSO, then it opens OK in LO in master and before. 
So I didn't understand what was the issue and what was changed.
Comment 6 Timur 2020-03-31 09:31:49 UTC
Created attachment 159179 [details]
Sample file resaved in MSO 2013