| Summary: | Problem scrolling past lines 999 & 1000 in the LibreOffice Calc Macro editor, in either direction if View - Line Numbers enabled | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Philip Russell <PhilipRussell31> |
| Component: | BASIC | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, j.ragan, xiscofauli, y_katoh |
| Priority: | medium | ||
| Version: | 4.1 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.0.0 target:6.4.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | sample file | ||
|
Description
Philip Russell
2020-02-25 11:10:33 UTC
I can reproduce it in Version: 7.0.0.0.alpha0+ Build ID: e6b9bc3f2ecf0fb7fde5b02f9d750ccbe022f4c1 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded after some time scrolling, the view goes back to the original position I can also reproduce it in Version: 6.0.0.0.alpha1+ Build ID: 6eeac3539ea4cac32d126c5e24141f262eb5a4d9 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; Locale: en-US (en_US.UTF-8); Calc: group threaded Created attachment 158179 [details]
sample file
Steps to reproduce: 1. Open attached document 2. Edit the macro 3. Go to the bottom of the macro 4. scroll up. Around line 1000 the view goes back to the bottom Same if scrolling down from line 1 to line 1000. I think the problem is with the line numbers. it breaks when it adds/removes one more digit ( 999 to 1000 ) Also reproduced in Version: 5.2.0.0.alpha0+ Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 Threads 4; Ver: 4.19; Render: default; Also reproduced in Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) @Caolán, I thought you might be interested in this issue... if we took the max line number of the full document, and not the max line number of the currently rendered range, the issue wouldn't arise, so I'll try that *** Bug 121444 has been marked as a duplicate of this bug. *** *** Bug 116743 has been marked as a duplicate of this bug. *** Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ca79c018f1e8bd0e1f42e3cef4b4f5893ef2e47f tdf#130925 use the maximum document line number for the width calculation It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I imagine that solves it, though testing appreciated Verified in Version: 7.0.0.0.alpha0+ Build ID: c8d764b3f27c2bb0712745891b70630e94436317 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded @Caolán, thanks for fixing this issue! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/c3143b5db45ca84267a4bc9c897fb4077e33d128 tdf#130925 use the maximum document line number for the width calculation It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |