| Summary: | Drop rtl::math::isNan in favor of std::isnan | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mike Kaganski <mikekaganski> |
| Component: | LibreOffice | Assignee: | Yukio Siraichi <yukio.siraichi> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | himajin100000, mentoring, sberg.fun |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicCleanup |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Mike Kaganski
2020-02-27 06:06:15 UTC
It is fine to remove uses of that rtl::math function across the LO code base. But the function is part of the stable URE interface, so cannot easily itself be removed. (We can think about an [API CHANGE] to drop this and similar inline functions from rtl/math.hxx once all of them are unused across the LO code base.) Yukio Siraichi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3bf3face224a7e12ba95888821a0ac21525af22c tdf#130975 replace `rtl::math::isNan` with `std::isnan`. It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |