| Summary: | Calc crashes when viewing details of two Statistical functions in Function Wizard | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Steve Fanning <stevemfanning.wh> |
| Component: | Calc | Assignee: | Eike Rathke <erack> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | caolan.mcnamara, erack, serval2412, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, haveBacktrace, needUITest, regression |
| Version: | 5.3 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=131380 https://bugs.documentfoundation.org/show_bug.cgi?id=94635 |
||
| Whiteboard: | target:7.0.0 target:6.3.6 target:6.4.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | bt with debug symbols (gtk3) | ||
|
Description
Steve Fanning
2020-03-03 15:18:06 UTC
Reproduced in Version: 7.0.0.0.alpha0+ Build ID: 37b4784ca722aa0496cda95191869c2086223e24 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Regression introduced by: author Winfried Donkers <winfrieddonkers@libreoffice.org> 2016-09-15 13:39:35 +0200 committer Eike Rathke <erack@redhat.com> 2016-10-13 19:04:48 +0000 commit fb790880eb11552b2e7d1dcf6c09d2663712290f (patch) tree a4626267b442f2fee3ef81186d053cb93d900187 parent 7d5d5e6e9b67807560a7db4123e8b41cc0f70a32 (diff) tdf#94635 follow up; handle linear data properly when samples in period Bisected with: bibisect-linux-64-5.3 @Julien, would it be possible to have a backtrace here? Created attachment 158354 [details]
bt with debug symbols (gtk3)
On pc Debian x86-64 with master sources updated today, I could reproduce this.
If I revert the quoted commit + fix merge conflict +
apply this:
diff --cc sc/source/core/tool/interpr8.cxx
index 39706cf7882c,5f98f269bbe1..000000000000
--- a/sc/source/core/tool/interpr8.cxx
+++ b/sc/source/core/tool/interpr8.cxx
@@@ -193,6 -195,11 +193,11 @@@ bool ScETSForecastCalculation::Preproce
}
}
- if ( rSmplInPrd != 1 )
- mnSmplInPrd = rSmplInPrd;
++ if ( nSmplInPrd != 1 )
++ mnSmplInPrd = nSmplInPrd;
+ else
+ mnSmplInPrd = CalcPeriodLen();
+
// Month intervals don't have exact stepsize, so first
// detect if month interval is used.
// Method: assume there is an month interval and verify.
* Unmerged path sc/qa/unit/data/functions/fods/forecast.ets.mult.fods
I don't reproduce the crash.
Patch submitted here for review: https://gerrit.libreoffice.org/c/core/+/89926 Patch abandoned, no idea why Jenkins fails. Hi Eike, I thought you might be interested in this issue... Hi Caolán, I thought you might be interested in this issue after you fixed bug 131380 I'm taking this. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/811b36e4db240be3a21a4d184b085630efcc09b7 Resolves: tdf#131096 Handle argument error and propagate It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/c/core/+/91181 for 6-4 https://gerrit.libreoffice.org/c/core/+/91182 for 6-3 Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/cddb53f5678fde8ad247524561f423b6498b29eb Resolves: tdf#131096 Handle argument error and propagate It will be available in 6.3.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/f2f32b267f1b17cec4599c6bd6a7c13c3ee6d434 Resolves: tdf#131096 Handle argument error and propagate It will be available in 6.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 7.0.0.0.alpha0+ Build ID: 169a10f0e4680814145b668c6320be04038d7a89 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded @Eike, thanks for fixing this issue!! Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-4-3": https://git.libreoffice.org/core/commit/b9728374522326364d8d579360319f7b7ebe639b Resolves: tdf#131096 Handle argument error and propagate It will be available in 6.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |