Bug 131465

Summary:	Icon in Gallery properties not scaled uniformly
Product:	LibreOffice	Reporter:	Buovjaga <ilmari.lauhakangas>
Component:	UI	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	VERIFIED FIXED
Severity:	trivial	CC:	caolan.mcnamara
Priority:	low	Keywords:	bibisected, bisected, regression
Version:	4.4.0.3 release
Hardware:	All
OS:	All
Whiteboard:	target:7.0.0
Crash report or crash signature:		Regression By:

Description Buovjaga 2020-03-21 14:15:30 UTC

1. Open the Gallery sidebar deck
2. Right-click theme -> Properties

Observe the icon in the General tab is much wider than it is taller, giving a squished look.

Bibisected on linux with 44max to
https://gerrit.libreoffice.org/plugins/gitiles/core/+/eaa89db886ba49472e22d77cea957a08c1113cd0%5E!/
tweak massively complicated html export wizard a bit

I tested a change in vcl/source/window/builder.cxx
I removed |WB_SCALE from

pWindow = new FixedImage(pParent, WB_CENTER|WB_VCENTER|WB_3DLOOK|WB_SCALE);

After this change and recompiling, the icon was uniformly scaled, but rather small.

Adding Cc: to Caolán McNamara

Comment 1 Caolán McNamara 2020-03-21 21:27:26 UTC

we can probably do something about that stretched image

Comment 2 Commit Notification 2020-03-22 19:39:12 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/13aed54fda6d84e1a0f6c080a7b2d83f793725c5

tdf#131465 image is stretched to fit allocation

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Buovjaga 2020-03-23 16:13:50 UTC

Thanks, verified!

Arch Linux 64-bit
Version: 7.0.0.0.alpha0+
Build ID: f2f93434f4795646255e5d8edd31fa08b8b2ffab
CPU threads: 8; OS: Linux 5.5; UI render: default; VCL: kf5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 23 March 2020