Bug 131722

Summary: FILEOPEN DOCX Date picker control placeholder texts first character goes out of the control
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: WriterAssignee: Czeber László Ádám (NISZ) <czeber.laszloadam>
Status: VERIFIED FIXED    
Severity: normal CC: aron.budea, buzea.bogdan, jluth, kelemeng, vmiklos, zolnaitamas2000
Priority: medium Keywords: bibisected, bisected, implementationError
Version: 6.4.0.3 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=121902
Whiteboard: target:7.6.0 target:7.5.4
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 113363    
Attachments: Example file from Word
Screenshot of the original document side by side in Word and Writer, after picking some dates

Description NISZ LibreOffice Team 2020-03-30 16:44:53 UTC
Created attachment 159157 [details]
Example file from Word

A date picker content control, if placed in a table, loses the first placeholder character when opened in Writer. 
The placeholder text is replaced when selecting a date, but the first character of the text stays in the document just before the control.
This happens only if the control is in a table, not if it is in the document body.

Steps to reproduce:
1.	Open attached document in Word and Writer
2.	Select a date from the controls in the document body and in the table.

Actual results:
In Writer the first character of the placeholder text stays in the table cell.

Expected results:
All of the placeholder text disappears.

LibreOffice details:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: bc898e2c2784e36ad4d4cdf6d962e39069d2c82d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Also happens in:
Verzió: 6.4.0.3 (x86)
Build az.: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: alapértelmezett; VCL: win; 
Területi beállítások: hu-HU (hu_HU); Felület nyelve: hu-HU
Calc: CL

But not in earlier versions, in 6.2-6.3 these became plain text, in 6.1 and before it was imported as date field UNO control, different from the date picker now.

Bibisected using bibisect-win64-6.4 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=68e1be4ccbb90ee9a788962219a88312c4ffbea2 
author	Tamás Zolnai <tamas.zolnai@collabora.com>	2019-07-10 18:22:31 +0200
committer	Tamás Zolnai <tamas.zolnai@collabora.com>	2019-07-12 12:55:40 +0200
summary: MSForms: Rework text-based date form field's representation

Adding CC to: Tamás Zolnai
Comment 1 NISZ LibreOffice Team 2020-03-30 16:45:45 UTC
Created attachment 159158 [details]
Screenshot of the original document side by side in Word and Writer, after picking some dates
Comment 2 Durgapriyanka 2020-03-30 20:56:55 UTC
Thank you for reporting the bug. I can confirm the bug present in

Version: 6.4.0.0.alpha1+ (x86)
Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 3 QA Administrators 2022-04-01 03:39:30 UTC Comment hidden (obsolete)
Comment 4 Gabor Kelemen (allotropia) 2022-06-30 22:20:37 UTC
Still a problem in:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 9c796266470183f673eb58a8637dfe621eefa8b3
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 5 Justin L 2022-12-06 14:54:59 UTC Comment hidden (not_clean_master, obsolete)
Comment 6 Justin L 2022-12-06 16:00:11 UTC
Repro 7.5 master with Date entry-example.docx for the first in-table date, which is a BlockSdt (i.e. the paragraph is inside the contents as opposed to a RunSdt which is inside a paragraph).

The second in-table date (which is a RunSdt) was fixed in LO 7.4 with
commit 5ee8670f18cb8b1913a23d04590d6a31ac9730de
Author: Miklos Vajna on Mon May 30 09:00:25 2022 +0200
    sw content controls, date: add DOCX import
Comment 7 Commit Notification 2023-04-27 16:48:00 UTC
Czeber László Ádám committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fd79c5ed9b13516bdb0f2a29806296698ddda7b2

tdf#131722 DOCX import: fix lost first character in date selector

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 BogdanB 2023-04-27 18:08:13 UTC
You can mark as Resolved

Everything fine with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b88d11ba05085002cf847d4828ded52a3dfb3b09
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Bad in
Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.2
Calc: threaded
Comment 9 BogdanB 2023-04-28 06:24:08 UTC
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b88d11ba05085002cf847d4828ded52a3dfb3b09
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 10 Commit Notification 2023-04-28 15:49:53 UTC
Czeber László Ádám committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/855a14d4ca43b517884046eec7e7c75f44a9e975

tdf#131722 DOCX import: fix lost first character in date selector

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.