Bug 131814

Summary: UI Close button on Table Data toolbar
Product: LibreOffice Reporter: NISZ LibreOffice Team <libreoffice>
Component: BaseAssignee: Gabor Kelemen (allotropia) <kelemeng>
Status: VERIFIED FIXED    
Severity: normal CC: buzea.bogdan, heiko.tietze, kainz.a, mentoring, nemeth, xiscofauli
Priority: medium Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Version: 6.3.0.4 release   
Hardware: All   
OS: All   
Whiteboard: target:7.0.0
Crash report or crash signature: Regression By:
Attachments: Screenshot of the problem in Writer

Description NISZ LibreOffice Team 2020-04-02 08:44:26 UTC 
Created attachment 159257 [details]
Screenshot of the problem in Writer

The Table Data toolbar of Base appears when one views the Data Sources in Writer. This is most useful when one is doing mail merge, and there is an icon for showing/hiding it on the Mail Merge toolbar.

Recently Table Data toolbar got a Close button that closes the current document. 
This is rather unexpected and confusing from an embedded view: I’d expect it closes the view only, if anything. 
But since it is easy enough to hide the Data Sources view (View menu, shortcut key or MM toolbar button), please just remove it.

Steps to reproduce:
1.	Open Writer, type some text
2.	Choose View – Data Sources

Actual results:
There is a Close button at the end of the Table Data toolbar.

Expected results:
No Close button.

LibreOffice details:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: bc898e2c2784e36ad4d4cdf6d962e39069d2c82d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Bibisected using bibisect-win32-6.3 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4f810905fa74128871f2fe924a3d28a79f4e4261
author: andreas kainz <kainz.a@gmail.com>
committer: andreas kainz <kainz.a@gmail.com>
summary: sync dbaccess ui files with swriter ui file structure

Adding CC to: Andreas Kainz
Comment 1 Xisco Faulí 2020-04-02 10:23:46 UTC 
Reproduced in

Version: 7.0.0.0.alpha0+
Build ID: 169a10f0e4680814145b668c6320be04038d7a89
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 2 Heiko Tietze 2020-04-02 11:23:17 UTC 
(In reply to NISZ LibreOffice Team from comment #0)
> But since it is easy enough to hide the Data Sources view (View menu,
> shortcut key or MM toolbar button), please just remove it.

+1

Code pointer: dbaccess/uiconfig/dbbrowser/toolbar/toolbar.xml
Comment 3 Commit Notification 2020-04-20 08:33:14 UTC 
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3d4f39628ecdef9ac080f46d197e5279caea8322

tdf#131814 Remove Close button from Table Data toolbar

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 BogdanB 2020-05-15 14:36:13 UTC 
It's ok now. The button is not there anymore.
Verified in 
Version: 7.0.0.0.alpha1+ (x64)
Build ID: 0e3196c49b84651df20b770d5cd7f0bbb19dfc40
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded