| Summary: | Font selection drop down menu expands right and button is too narrow | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Michel Le Bihan <michel> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | 79045_79045, aron.budea, buzea.bogdan, caolan.mcnamara, heiko.tietze |
| Priority: | medium | ||
| Version: | 7.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=132338 https://bugs.documentfoundation.org/show_bug.cgi?id=136943 |
||
| Whiteboard: | target:7.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 113438 | ||
| Attachments: |
Font selection drop down menu expanded
Comparison of font selection drop down button width Screenshot 6.3 vs. 7.0 |
||
|
Description
Michel Le Bihan
2020-04-26 16:34:24 UTC
Created attachment 159963 [details]
Font selection drop down menu expanded
Created attachment 159964 [details]
Comparison of font selection drop down button width
confirm in Version: 7.0.0.0.alpha1+ (x64) Build ID: 2f4172fc48aab38c64851ba3a384bd6c7c180634 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; Locale: ru-RU (ru_RU); UI: en-US Calc: threaded but not in 6.4 => regression Caolan, I thought the MAX_MRU_FONTNAME_ENTRIES = 5 controls the number of entries shown in menus (should be 8 by default). Why is it much more, leading to a misplaced menu on Windows with a small screen, but also on Linux? I count 20+1 items. For the control width, I think COMBO_WIDTH_IN_CHARS=18 or 20 is needed (which makes the toolbar larger). The expander button is just larger. Created attachment 160711 [details] Screenshot 6.3 vs. 7.0 Version: 7.0.0.0.alpha1+ Build ID: 8664137ca0f6683d86ee6498d12f7d174aa2a1fc CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded KDE with Breeze-Dark theme for Gtk apps. MAX_MRU_FONTNAME_ENTRIES controls the number of elements in the "most recently used" portion of the menu, not the number of overall elements in the menu. A normal vcl combobox lists show a maximum number of "ListBoxMaximumLineCount" lines as set by officecfg/registry/schema/org/openoffice/Office/Common.xcs which is 25 at the moment That font dropdown contains custom rendered elements, but the height is currently set to approximately what height it would have if it was a normal combobox list, the positioning after that is whatever vcl always did when a menu got that high. wrt widget width, there is no value which can be set there which does not cause complaint so leave that as a separate issue to the height. https://gerrit.libreoffice.org/c/core/+/94065 wrt up/down placement of the menu if it wouldn't fit on screen Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/822f94e260b8351dc3459d2c05180af2de96d4c7 tdf#132435 only place menu vertically if up/down requested It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/535d857975e453401c0c455bdda82e1a81c7e110 Resolves tdf#132435 - Font selection drop down too narrow It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to Commit Notification from comment #9) > https://git.libreoffice.org/core/commit/ > 535d857975e453401c0c455bdda82e1a81c7e110 This patch makes the dropdown show 18 characters, enough for the full font name as in the past. The toolbar becomes a bit larger by that. Together with Caolan's patch it's fixed now. It's ok. Verified in Version: 7.0.0.0.beta2+ Build ID: 77e4943cc6cf206a45901e5c87fabf0f783c8262 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-0, Time: 2020-06-24_02:22:53 Calc: threaded |