| Summary: | Dragging color from Color Bar to color field of interactive gradient tool is broken | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Regina Henschel <rb.henschel> |
| Component: | Draw | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=134285 https://bugs.documentfoundation.org/show_bug.cgi?id=134396 https://bugs.documentfoundation.org/show_bug.cgi?id=142150 |
||
| Whiteboard: | target:7.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Illustration of the situation | ||
|
Description
Regina Henschel
2020-04-27 14:40:04 UTC
It is OK in Version: 7.0.0.0.alpha0+ (x64) Build ID: 6388c578c672690fff662cb04b6a0436cd742f37 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win; Locale: de-DE (en_US); UI-Language: en-US Calc: threaded So quite new regression. Reproduced in Version: 7.0.0.0.alpha1+ Build ID: 1ffe59ef31186e36ad0aa7bbcdd32e407ee8d26c CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3d79f395ea6b0a960051615a98bfe58387c7d231 author Caolán McNamara <caolanm@redhat.com> 2020-04-24 20:34:32 +0100 committer Caolán McNamara <caolanm@redhat.com> 2020-04-25 21:50:47 +0200 commit 3d79f395ea6b0a960051615a98bfe58387c7d231 (patch) tree e8e2efabc9b7e88072c4fd338eb85a94314ac809 parent 96e5121869e95a8e28788a91ce0dc480e5f10c0b (diff) weld SvxColorDockingWindow Bisected with: bibisect-linux64-6.5 Adding Cc: to Caolán McNamara I'm not sure I see what's changed ? In 6.4 if a shape is selected and I click a color then the selected shape is changed to the clicked color. If no shape is selected I can drag a color from the colorbar and drop it over a shape and the shapes changes to the color. What interaction is different in master ? Created attachment 160819 [details]
Illustration of the situation
I have attached an illustration of what you need to do.
I think I understand now, dragging is possible, just useless because the color was set on the mouse down as opposed to on the mouse up, which had allowed a click, drag, drop, release to set the dragged color Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/23a1b7bad5147ee48d7f920085426d8846559af7 Resolves: tdf#132461 set color on mouse release, not press It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. does that solve the problem ? Verified in Version: 7.0.0.0.alpha1+ Build ID: 8209c2569f5726f9ed29f75d30efdccb94f98fe5 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, thanks for fixing this issue! |