Bug 132623

Summary: Custom properties dialog contents don't expand to fill the dialog when resized
Product: LibreOffice Reporter: Aron Budea <aron.budea>
Component: UIAssignee: andreas_k <kainz.a>
Status: VERIFIED FIXED    
Severity: minor CC: kainz.a, serval2412, xiscofauli
Priority: medium Keywords: bibisected, bisected, regression
Version: 6.4.0.3 release   
Hardware: All   
OS: All   
Whiteboard: target:7.0.0 target:6.4.5
Crash report or crash signature: Regression By:
Attachments: screenshot with gen rendering

Description Aron Budea 2020-05-03 06:15:12 UTC 
This can be reproduced with gen backend or in Windows, gtk3 is fine.

Open File -> Properties, switch to Custom Properties tab, and expand the dialog in both directions.

=> The property list widget and the "Add Property" button should expand/move to fill the dialog, but they don't.

This is a regression from the following commit.
Andreas, this seems to be the first change from the commit. Perhaps those attributes don't need to be set in other places, but here they seem to be important, are you okay with having them readded?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7b1667d9500d541f57a8a4401ec1fc8bd238fa29
author		andreas kainz <kainz.a@gmail.com>	2019-11-08 02:20:51 +0100
committer	andreas_kainz <kainz.a@gmail.com>	2019-11-08 09:22:50 +0100

Writer Property Dialog update
Comment 1 Julien Nabet 2020-05-03 09:41:12 UTC 
Created attachment 160270 [details]
screenshot with gen rendering

On pc Debian x86-64 with LO Debian package 6.4.3 + gen rendering, I don't see anything wrong here.
Comment 2 Julien Nabet 2020-05-03 09:43:43 UTC 
Status of this bugtracker is ASSIGNED but there's nobody assigned.

Andreas: are you ok to be assigned on this one? If no, we'll put it back to UNCONFIRMED.
Comment 3 andreas_k 2020-05-03 10:40:39 UTC 
I assigned it and patch is already in Gerrit.
Comment 4 Julien Nabet 2020-05-03 10:47:09 UTC 
Thank you for your feedback, let's fill the Assignee field.
Comment 5 Commit Notification 2020-05-03 11:06:52 UTC 
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/72d29798faac7bee311219b48d4a8373e6d50da3

tdf#132623 custom property dialog expand update

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Aron Budea 2020-05-03 22:57:50 UTC 
The content expands correctly with the patch, thanks for te fix, Andreas!
Comment 7 Xisco Faulí 2020-05-05 15:11:28 UTC 
Verified in

Version: 7.0.0.0.alpha0+
Build ID: 017f90788c330d2e35a9c05a5...
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Andreas, thanks for fixing this issue!
Comment 8 Commit Notification 2020-05-06 08:03:27 UTC 
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/e084f4daa13bfcc79cd30f7139c25e97210037b2

tdf#132623 custom property dialog expand update

It will be available in 6.4.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.