| Summary: | FILESAVE: Bug when you apply customized gradient to paragraph and then save/open | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Mauro <mgiubileo> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | buzea.bogdan, jluth, kelemeng |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.3.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=142144 https://bugs.documentfoundation.org/show_bug.cgi?id=125449 https://bugs.documentfoundation.org/show_bug.cgi?id=99908 https://bugs.documentfoundation.org/show_bug.cgi?id=154817 |
||
| Whiteboard: | target:7.3.0 target:7.2.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Mauro
2020-05-06 14:18:11 UTC
I can confirm the bug even on Ubuntu Linux 18.04 LTS. It uses: LibreOffice Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.10 Repro 7.2+. Not seen in 6.0, seen in 6.1, regression. I don't see the problem in 6.1 or 6.2. Regression started in 7.0 and backported to 6.3.4. Using bibisect-linux-x64-6.3, I got commit 53c474633c4e658f096669fb0225d751a5701aaf author Gabor Kelemen on Tue Nov 19 10:25:49 2019 +0100 tdf#125449 Fix custom gradient fill settings being lost https://git.libreoffice.org/core/+/53c474633c4e658f096669fb0225d751a5701aaf%5E%21 For my testing, I selected the blue radial gradient, and then changed the setting from radial to elliptical. When re-loaded, the result was linear with black/white. A workaround is to assign a unique name to a custom gradient/hatch as implemented in SD. (https://gerrit.libreoffice.org/c/core/+/107258 which contains links to unit tests in the comments). Needed here in Writer for hatches and gradients too. sw/source/uibase/shells/textsh1.cxx case SID_PARA_DLG: As noted in one commit > However tdf#99908 shows that ODF import doesn't like anonymous > gradients. This is a bug in xmloff style import and should eventually > be fixed there. Here we implement the same band-aid solution > tdf#99908 implements for Impress sidebar proposed fix at https://gerrit.libreoffice.org/c/core/+/117594 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3f6797c29e9672eba354400f24a669244fd746c0 tdf#132776 sw UI: make unique names for custom hatch and gradient It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/357e52fd878225d5b7a23eda53514e076b2cd61a tdf#132776 sw UI: make unique names for custom hatch and gradient It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Solved. Verified in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: eac5977bfc11797eda356560a5e45c51108ef5a1 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded |