| Summary: | Fontbox empty for the whole document after applying a character style after undo without changing the selection first (see comment 12) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | buzea.bogdan, caolan.mcnamara, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.0.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Example file
how works on linux Screencast confirm it Bibisect log Example file |
||
|
Description
Telesto
2020-05-14 18:48:33 UTC
I meant, but not in Version: 5.4.0.3 Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c CPU threads: 4; OS: Windows 6.2; UI render: default; Locale: nl-NL (nl_NL); Calc: CL You didn't attach the file. Created attachment 160831 [details]
Example file
Created attachment 160874 [details] how works on linux Can not repro on Version: 7.0.0.0.alpha1+ Build ID: b1e396d86655a0131498a4691dd8069ea76c3477 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-05-15_04:58:38 Calc: threaded See the video. Maybe is just on Windows. Created attachment 160876 [details]
Screencast
If no one will test this until Tuesday on Windows, I will test it then. At work. (In reply to BogdanB from comment #6) > If no one will test this until Tuesday on Windows, I will test it then. At > work. Will work on Linux :-), I think. It's rather specific.. Don't deselect ABC after Undo.. but leave it as is. an select the character style AAA Created attachment 160877 [details] confirm it I confirm it on Version: 7.0.0.0.alpha1+ Build ID: b1e396d86655a0131498a4691dd8069ea76c3477 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-05-15_04:58:38 Calc: threaded I will try to bibisect it. Confirm it in Version 3.6.7.2 (Build ID: e183d5b) Confirm it in Version: 5.4.7.2 Build ID: c838ef25c16710f8838b1faec480ebba495259d0 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk2; Locale: ro-RO (ro_RO.UTF-8); Calc: group And in all later versions Created attachment 161096 [details] Bibisect log Bisected to author Caolán McNamara <caolanm@redhat.com> 2020-04-25 20:17:05 +0100 committer Caolán McNamara <caolanm@redhat.com> 2020-04-25 22:43:39 +0200 commit d26d1da82f0625ce1e5a99cc0081b1fcf422b315 (patch) tree 5f4fa18baa60dc09f24b4681dc04b3a76599244e parent 33966ab25d21594a3a4f40ce30ece73fa4f45a27 (diff) rename SvtValueSet back to ValueSet https://cgit.freedesktop.org/libreoffice/core/commit/?id=d26d1da82f0625ce1e5a99cc0081b1fcf422b315 Created attachment 161097 [details]
Example file
STR used for bibisect
1. Open the attached file
2. Merge cell z with two bottom cells
Adding CC to Caolán McNamara are comment #11 and #12 for this bug ? I see the problem of comment #1 in master, but I also see it in e.g. 4.1 which precedes the identified commit by many years (In reply to Caolán McNamara from comment #14) > are comment #11 and #12 for this bug ? I see the problem of comment #1 in > master, but I also see it in e.g. 4.1 which precedes the identified commit > by many years Yes, comment 11 and 12 or for this bug.. Should have added an additional step Steps to Reproduce: 1. Open the attached file 2. Select ABC and drag to next column 3. CTRL+Z 4. Select/ Apply Character Style AAA -> Notice the empty (old bug 4.1) 5. Switch to a different table cell -> Still empty (new) -> Comment 12 as alternative The very old bug, is not so interesting.. it limited to very specific issue.. moving the a different cell and back and resolved.. the new one is sticky.. But, yes, I found the new bug, by looking at the 4.1 bug.. so the bug is a bit of mess. I see the new problem alright. I'll take this for the new problem in 7. I don't think the bisect is right, but I think it bisects to another of my changes anyway. (In reply to Caolán McNamara from comment #16) > I'll take this for the new problem in 7. OK! > I don't think the bisect is right, but I think it bisects to another of my changes anyway. Oops! Thanks for letting me know. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fcce0642c101429247a8be886df5a469aeb390a2 tdf#133043 explicitly set the combobox edit text It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. I believe that fixes the new problem @Telesto, could you please verify the issue is fixed ? I don't know which steps should I use to verify it Working as expected Version: 7.1.0.0.alpha0+ (x64) Build ID: 83c4f86f22dc37269ac6a038fe7de053c42aad6e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL Thanks Caolán |