Bug 133351

Summary:	Memory usage increased a lot with (large) animated gifs
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	Impress	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED NOTABUG
Severity:	normal	CC:	aron.budea, ilmari.lauhakangas
Priority:	medium	Keywords:	bibisected, bisected, perf
Version:	6.1.0.3 release
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	116280
Attachments:	Bibisect log

Description Telesto 2020-05-24 15:44:50 UTC

Description:
Memory usage increased a lot with (large) animated gifs

Steps to Reproduce:
1. Open attachment 161222 [details]
2. Open a process monitor (monitoring mem usage)
3. Switch to the second slide -> wait.. all frames are stored in a buffer (200 MB)
4. Switch to next slide -> 30 increase
5. Go to next slide -> 30 mb increase
6. Go the next slide -> 70 mb increase etc. go on and on until the end

Actual Results:
700 MB ram at the end

Expected Results:
220 MB as before


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1+ (x64)
Build ID: b587de60d4e6aa96238766272d94f1499b22f696
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
6.1

Comment 1 Telesto 2020-05-24 15:45:48 UTC

Created attachment 161236 [details]
Bibisect log


author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2018-04-04 17:51:26 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2018-04-12 14:35:14 +0200
commit a2b53fece14f745853bcfe1a300c3dceb580e148 (patch)
tree c4d287f97140363fe9cec7740b5189032e8f114e
parent 92ac45b1920fcce8259c1eab94357415e8f50d82 (diff)
vcl: Add a internal (memory) manager for Graphic objects
This adds vcl::graphic::Manager which is a manager singleton that
tracks all the creation fo graphic objects and swaps them out on
a time and allocation basis.

Time based - every number of seconds it looks for Graphics that
weren't used for a time.

Allocation based - when creating a new Graphic and the total of
Graphic uses more than the total amount of memory for Graphics
defined in configuration, it tries to release the Graphics that
weren't used for a time.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a2b53fece14f745853bcfe1a300c3dceb580e148

Comment 2 Buovjaga 2020-06-18 17:49:26 UTC

Based on the commit description this seems to be working as intended, so closing.