Bug 133655

Summary:	Image in section is outside section at after undo and moves to the original position after save & reload
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	Writer	Assignee:	Michael Stahl (allotropia) <michael.stahl>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	buzea.bogdan, dgp-mail, michael.stahl
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	6.2.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=138618
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	105948, 107738, 138327
Attachments:	Screenshot Bibisect log

Description Telesto 2020-06-03 21:48:01 UTC

Description:
Image at wrong position after undo and moves to the original position after save & reload 

Steps to Reproduce:
1. Open attachment 127476 [details] (bug 91993 and bug 132420)
2. CTRL+A CTRL+A
3. CTRL+X
4. CTRL+Z

Actual Results:
See PDF export

Expected Results:
Original position


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 83c4f86f22dc37269ac6a038fe7de053c42aad6e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Comment 1 Telesto 2020-06-03 21:48:42 UTC

Not in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

Comment 2 Telesto 2020-06-03 21:49:23 UTC

Created attachment 161596 [details]
Screenshot

Comment 3 Telesto 2020-06-04 10:44:16 UTC

Not in 6.1, but in 6.2

Comment 4 Telesto 2020-06-04 16:52:19 UTC

Created attachment 161616 [details]
Bibisect log

Bisected to:
author	Michael Stahl <Michael.Stahl@cib.de>	2018-08-22 17:09:02 +0200
committer	Michael Stahl <Michael.Stahl@cib.de>	2018-09-19 10:18:29 +0200
commit 723728cd358693b8f4bc9d913541aa4479f2bd48 (patch)
tree 1ac75a662a46987301ea85d32957eb08f435ffd6
parent 41d8ca9686c7c184f586e99674b443c34bfd4f33 (diff)
sw_redlinehide_2: SwUndoDelete
This is problematic because of the calls to SplitNode.
Ideally we'd want the SplitNode to create merged frames already, but
that doesn't seem to be easy to achieve; several problems with this are:

1. the redlines are only restored at the end of UndoImpl
2. even if we store another set of SwRedlineSaveDatas right before the
   Join (while preventing the first SwRedlineSaveDatas from deleting
   them), and restore them by passing a closure to SplitNode, there
   are complaints about empty redlines, and also this case isn't
   handled properly:

     f<delete start>o<redline start>o
     b<redline end>a<redline start>r
     b<redline end>a<delete end>z

So instead, let SplitNode create whatever frames it does, and fix it up
at the end manually on the start node's frames.

This necessitates delaying the creation of the frames on the moved nodes
until the end too.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=723728cd358693b8f4bc9d913541aa4479f2bd48

Comment 5 Dieter 2020-11-21 17:52:45 UTC

I confirm it with

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

Comment 6 Telesto 2021-01-16 19:02:36 UTC

Adding CC: to Michael Stahl

Comment 7 Michael Stahl (allotropia) 2021-12-20 14:15:27 UTC

fixed by commit 2b256c84aa4c063c8161b32a7b424daa28b5741b

*** This bug has been marked as a duplicate of bug 136452 ***