| Summary: | Hyperlink dialog: select "Frame" by clicking the textbox | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | bugzilla2 |
| Component: | UI | Assignee: | Andreas Heinisch <andreas.heinisch> |
| Status: | VERIFIED FIXED | ||
| Severity: | enhancement | CC: | buzea.bogdan, heiko.tietze, samuel.mehrbrodt |
| Priority: | medium | ||
| Version: | 6.0 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=92869 | ||
| Whiteboard: | target:7.5.0 target:7.4.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 112125 | ||
|
Description
bugzilla2
2020-06-04 14:04:20 UTC
My other hyperlink-dialog-related Bug: 123123 Cannot reproduce with LO 6.4.2.2 on Windows. Can you try with a recent version please? Ah sorry, I tried the "Form" dropdown instead of the "Frame" combo box. The reason this does not pop down is, that it's a different widget. It's a combo box with editable content. @UX: Does it make sense to replace the "Frame" combo box with a dropdown? (In reply to Samuel Mehrbrodt (CIB) from comment #3) > @UX: Does it make sense to replace the "Frame" combo box with a dropdown? If the number of items is limited to the predefined the dropdown is the correct widget. And I don't see what a user can enter here. So yes, please make it a dropdown. Well, a serious webdesigner could need custom frame-targets, but I doubt, that a serious webdesigner uses Writer for HTML-Editing ;) The box is still a editbox and not a dropdown in 7.0 and 7.1 series Could the frame also be empty? Or should it have a default target frame? Thanks for taking that bug :) The default should be empty. Btw, "empty" means, that no tag is written at all. So the resulting code should be: <a href="foo">foo</a> and NOT <a href="foo" target="">foo</a> Not sure if that has something to do with replacing the combo-box though :D I will check if the target won't be written if the traget is not empty. Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e8f97879c4e677107551692fa88b0791f70bd413 tdf#133675 - Hyperlink dialog: change frame widtget from editbox to dropdown It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Andreas Heinisch committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/f78ce524ad8efce5181a47b63d01b4439a3fd03c tdf#133675 - Hyperlink dialog: change frame widtget from editbox to dropdown It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. The patch sems to work fine. Tested with current master, the selection of the target is easier now. I also tested what happens, if you open a html-file that has a custom target -> nothing, no crash, or something :) Of course it doesn't "display" the custom target, but thats ok. Writer breaks that html file so much, that the target would be the least problem. So no web-developer would like to edit his html-files with Writer, exept some noobs maybe, and they should be fine with the predefined targets anyway. Fix verified in: Version: 7.4.3.2 / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Andreas! |