| Summary: | Number of columns in large sheets 16385 (XFE) instead of XFD (16384) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | [REDACTED] <noreply+70426> |
| Component: | Calc | Assignee: | Aron Budea <aron.budea> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | 79045_79045, aron.budea, noelgrandin |
| Priority: | medium | ||
| Version: | 7.0.0.0.beta1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.1.0 target:7.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 133764 | ||
|
Description
[REDACTED]
2020-06-10 10:55:24 UTC
Forgot to mention my system data. Version: 7.0.0.0.beta1, Build ID: 94f789cbb33335b4a511c319542c7bdc31ff3b3c CPU threads: 4; OS: Linux 4.12; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US, Calc: threaded confirm in Version: 7.0.0.0.beta1+ (x64) Build ID: c46a704943be830d603ba0421a329ccb58b8b209 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded but i don't think it's a bug... At least it is an inconsistency of what is stated in the settings dialog and what you finally get. I addition the fact that the number of columns doesn't match a power of 2 boundary (2^14) seems suspicious (to me - sorry got no better wording). Noel, is there a reason why the JUMBO constants aren't set to max - 1, like the old ones? Ie. const SCROW MAXROWCOUNT = 1048576; const SCCOL MAXCOLCOUNT = 1024; ... const SCROW MAXROW = MAXROWCOUNT - 1; const SCCOL MAXCOL = MAXCOLCOUNT - 1; ... const SCROW MAXROW_JUMBO = 16 * 1000 * 1000; const SCCOL MAXCOL_JUMBO = 16384; https://opengrok.libreoffice.org/xref/core/sc/inc/address.hxx?r=32ff26f7&mo=2549&fi=70#73 Yes, that is a mistake, feel free to fix it Aron Budea committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8f53858381e0cd6a3391c4ce8a097cdafa9c8df0 tdf#133853 Large spreadsheets have 16385 columns instead of 16384 It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks for the confirmation, Noel! Fix pushed, not sure what the policy with experimental features is, but backport to 7.0 is on gerrit, in worst case it can be abandoned. Aron Budea committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/a71f463bb4118baa6f6ca1d8179e655733e5fa4a tdf#133853 Large spreadsheets have 16385 columns instead of 16384 It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. verified in Version: 7.1.0.0.alpha0+ (x64) Build ID: <buildversion> CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL build from 18 August 2020 |