| Summary: | Slow performance in autofilter if the record contains many unique values (10 seconds after 5.4 vs. 2 seconds before) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | Calc | Assignee: | Luboš Luňák <l.lunak> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | 79045_79045, kohei, l.lunak, noelgrandin, suokunlong, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, perf, regression |
| Version: | 5.4.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=105629 https://bugs.documentfoundation.org/show_bug.cgi?id=116633 https://bugs.documentfoundation.org/show_bug.cgi?id=122419 https://bugs.documentfoundation.org/show_bug.cgi?id=133835 https://bugs.documentfoundation.org/show_bug.cgi?id=133804 |
||
| Whiteboard: | target:7.2.0 target:7.1.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103512 | ||
| Attachments: |
Bibisect log
Example file Minimal test file |
||
|
Description
Telesto
2020-06-10 20:19:28 UTC
Created attachment 161860 [details] Bibisect log Bisected to author Kohei Yoshida <kohei.yoshida@collabora.com> 2017-01-30 22:01:45 -0500 committer Kohei Yoshida <libreoffice@kohei.us> 2017-02-02 05:01:53 +0000 commit 42e472b5870278058537d43d03d457dc80b16166 (patch) tree 68f9c7526463dc004f58a5c9a3bc81547b2b233f parent 5f33745c1d6750126e53a02b2a95355a3e5b16a0 (diff) tdf#105629: Let's move the advanced-filter specific stuff ... to the place where we actually parse the filtering rules for advanced filter queries. https://cgit.freedesktop.org/libreoffice/core/commit/?id=42e472b5870278058537d43d03d457dc80b16166 Created attachment 161861 [details]
Example file
Note: All autofilter drop down buttons are slow too after deselecting " 1" and pressing OK confirm in Version: 7.1.0.0.alpha0+ Build ID: 26483950760f0aac7bc45e93db4127f66a98fdc6 CPU threads: 4; OS: Mac OS X 10.15.5; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded Created attachment 165833 [details]
Minimal test file
Filtering in column A takes 14s in my PC.
This may due to column A contains too many unique values. I do encounter many cases when autofilter takes a lot of time when the field contains a lot of unique values in my daily work.
Attached is a minimal test case. Column A contains too many unique values: filtering in this column takes a lot of time. Column B contains only 3 unique values: filtering in this column takes only < 1s.
*** Bug 137086 has been marked as a duplicate of this bug. *** Hi Luboš, Noel, I thought you might be interested in this performance issue. The file from bug 137086 hangs for minutes *** Bug 138248 has been marked as a duplicate of this bug. *** Set importance to HIGH MAJOR as this regression impacts core functioning in Calc. I see Luboš Luňák has submitted a patch on gerrit: https://gerrit.libreoffice.org/c/core/+/106594 With this patch applied the filter is not done within 2 seconds. Those who can build by yourself should also test if there are regressions. Luboš Luňák committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/85cb9262644ebe376f9c5af1f01a0216a51a6d6d bring back optimized calc querying by value (tdf#133878) It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Luboš Luňák committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/8d29d0cee0b16df71134cd82d3fc0dbcdcd3dde3 bring back optimized calc querying by value (tdf#133878) It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |