| Summary: | UI EDITING Drawing a shape, the cursor is not precise (GTK3) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | sahdsg |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | minor | CC: | ilmari.lauhakangas, noelgrandin |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.3.0.0.alpha0+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.1.0 target:7.0.4 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103182 | ||
| Attachments: | Screenshot of the postion shift | ||
This should be a problem from https://opengrok.libreoffice.org/xref/core/vcl/unx/gtk3/gtk3gtkdata.cxx?r=aef7feb3#134 The cursor size changes but the "hot position" does not change. A temporary solution: 1. I go to system config and set default_cursor_size to 32 (it is 16 before) 2. Reboot Libreoffice 3. The cursor become precise 4. go to system config and set default_cursor_size to 16 5. The cursor is still precise Maybe it should not scale the cursor image. There is a new problem. For almost all shapes, the cursor becomes "DrawText". Many cursor icons are not used. Bibisected with Linux 6.3 repo to https://git.libreoffice.org/core/commit/25d176ada67ada550bd4d0d08177c232cf7eeb37 tdf#123796 Wrong cursor when inserting shape Adding Cc: to Noel Grandin This is not seen with kf5 or gen backends. under my Fedora wayland F32 gdk_display_get_default_cursor_size is already 32 so it works ok for me out of the box, under x11 its 24 and the problem arises Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/71f6e3862afc460536085582d3f9e9401096c24a tdf#133950 scale hotspot to sync with scaled cursors It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. well, that seems to fix it, alternatively not scaling the cursors is an option I suppose fixed in master, backport to 7-0 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/99e924f3faab58076221c7be326c697cb2dcf047 tdf#133950 scale hotspot to sync with scaled cursors It will be available in 7.0.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Looks like it's working, thanks Arch Linux 64-bit Version: 7.1.0.0.alpha1+ Build ID: 38dd55f6022a6ec217a2a54459a2875f1bef1f5e CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 28 October 2020 |
Created attachment 161942 [details] Screenshot of the postion shift In Draw, when drawing a shape, such as line, the mouse cursor will become a cross. However, the shape will have a position shift from the center of the cross. Steps to reproduce: 1. Create a Drawing 2. Display Grid 3. Disable "Snap to Grid" 4. Select "Insert Line" 5. Draw a line with the center of the cross on the grid 6. The line has a position shift This also happens in writer, presentation and calc. Version: 6.4.4.2 Build ID: 6.4.4-1 CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: gtk3; Locale: ; UI-Language: en-US Calc: threaded