Bug 134242

Summary:	Dragging an image slow in GDI mode (part 2)
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	Draw	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	aron.budea, ilmari.lauhakangas, mikekaganski, serval2412
Priority:	medium	Keywords:	bibisected, bisected, perf, regression
Version:	7.1.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=134241 https://bugs.documentfoundation.org/show_bug.cgi?id=134237
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	47148
Attachments:	Bibisect log

Description Telesto 2020-06-22 19:32:26 UTC

Description:
Dragging an image slow in GDI mode (part 2)

Steps to Reproduce:
1. Open attachment 162322 [details]
2. Drag the image around

Actual Results:
Choppy/slow

Expected Results:
Smooth


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 43c60ce1ac7629a1462e927e6ff937469f58f743
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Comment 1 Telesto 2020-06-22 19:33:47 UTC

Created attachment 162324 [details]
Bibisect log

Bisected to
author	Mike Kaganski <mike.kaganski@collabora.com>	2020-05-28 20:13:50 +0200
committer	Mike Kaganski <mike.kaganski@collabora.com>	2020-05-29 10:31:40 +0200
commit c644b2b4abe3051c0e0fc91674154c796fd326f6 (patch)
tree 391c0d15daa02bae90325a2d44b9a4cbbba01756
parent f510bdfa98014ca0ae596dcd0dfd487cfc90f3eb (diff)
Use buffer with alpha in VclProcessor2D::RenderUnifiedTransparencePrimitive2D
This allows UnifiedTransparencePrimitive2D to produce truly transparent image,
usable later in the stack - specifically by glow and soft edge effect.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c644b2b4abe3051c0e0fc91674154c796fd326f6

Comment 2 Buovjaga 2020-11-09 06:15:02 UTC

Repro

Adding Cc: to Mike Kaganski

Arch Linux 64-bit
Version: 7.1.0.0.alpha1+
Build ID: c9b320c32aceab7e22d381b688e7b44030e01c2d
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 8 November 2020

Version: 7.1.0.0.alpha1+ (x64)
Build ID: b61bf7c7cfcf97a5ade6d130873af146670bc2ee
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded

Comment 3 Julien Nabet 2022-09-15 19:38:18 UTC

On pc Debian x86-64 with master sources updated today or with LO Debian package 7.4.1.1 + kf5 rendering, I don't reproduce slowliness.

Could someone give a new try with recent LO version? Knowing that if 7.3.6 is slow, 7.4.1 should be tested since 7.3 branch is almost EOL.

Comment 4 Buovjaga 2022-09-16 07:11:31 UTC

I compared with Windows bibisect repo 7.1 and the problem is indeed fixed (also on Linux 7.4)!

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 922b79a0f5a9151a6870ba395abcac5b54055275
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo