| Summary: | FILESAVE DOCX Don’t add space between paragraphs of the same style not overridden | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | jluth, kendy, nemeth, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 4.2.0.4 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=125893 | ||
| Whiteboard: | target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 107830 | ||
| Attachments: |
Example file from Word
Screenshot of the original document side by side in Word and Writer The original file saved by Writer Screenshot of the original and exported document side by side in Word |
||
|
Description
NISZ LibreOffice Team
2020-06-29 10:25:16 UTC
Created attachment 162496 [details]
Screenshot of the original document side by side in Word and Writer
Created attachment 162497 [details]
The original file saved by Writer
Created attachment 162498 [details]
Screenshot of the original and exported document side by side in Word
Reproduced in Version: 7.1.0.0.alpha0+ Build ID: fa844c15233f108a0e9b0b2e8c9757c1aa088a4b CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded repro 7.2. Also true for .doc and .rtf formats. I bibisected this to 6.0 IMPORT patch: commit f8b5ecc622e2b3e82576b27bf0ded9c8eac21cae Author: Miklos Vajna on Oct 24 09:27:19 2017 +0200 tdf#113202 RTF import: fix lack of expected contextual spacing HOWEVER, I wasn't comparing with MS Word. MS Word 2016 also does display any spacing. So actually this 6.0 bibisect is a fix. So, if I bibisect using MS Word 2016 as the verifier, then I confirm NISZ's conclusion that it was in broken at LO 4.2 with: commit 33e97347ac5b1a3206ddcc2c8313c7e88461bb0b Author: Jan Holesovsky on Oct 9 14:39:35 2013 +0200 DOCX export: Write contextualSpacing only if it takes place. https://cgit.freedesktop.org/libreoffice/core/commit/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b So the fix here will be to see if it inherits contextualspacing == true, and in that case write out a false. (see https://gerrit.libreoffice.org/c/core/+/106315 for a similar case for character properties.) P.S. At this point, MSWord shows RTF with no spacing - same as with 7.2. However, DOC has spacing between every single one of the first five paragraphs (which was mysteriously fixed shortly thereafter in the range https://cgit.freedesktop.org/libreoffice/core/log/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b&qt=range&q=ff3b823ef4b867263711703fab596584314e4f58..fdba797bd9c2a3fe4de82f92c3ee815c15f8ac84) RTF has "\contextualspace", but no negation of that. So I don't think it is possible to cancel in RTF. (In MS Word, it removes \contextualspace from the string of formatting in front of Paragraph3.) Proposed fix at https://gerrit.libreoffice.org/c/core/+/113064 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5c90f3d28de6262bb730bad106d4652e458054df tdf#134385 doc/docxexport: maybe export false contextualspacing It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: aa9cb8e14749e7fb7a83b55a2bb095501f731a18 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: threaded |