| Summary: | FILEOPEN DOCX Paragraph after nested table gets unexpected spacing | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | buzea.bogdan, jluth, nemeth, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, filter:docx, regression |
| Version: | 7.0.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=133735 https://bugs.documentfoundation.org/show_bug.cgi?id=132514 |
||
| Whiteboard: | target:7.3.0 target:7.2.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 104444 | ||
| Attachments: |
Example file from Word
Screenshot of the original document side by side in Word and Writer docum_minimized.docx: with exaggerated spacing |
||
|
Description
NISZ LibreOffice Team
2020-07-06 13:46:34 UTC
Created attachment 162713 [details]
Screenshot of the original document side by side in Word and Writer
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=81ce88aa80f8e7cde4fdc5b211e9500a3599643c author László Németh <nemeth@numbertext.org> 2020-05-04 13:42:14 +0200 committer László Németh <nemeth@numbertext.org> 2020-05-04 17:55:28 +0200 commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c (patch) tree e343d94d8d304e97b82fe42efaabb810b6f3e04f parent 224c155d89e4d957c0d566a5aea6004a466d54e9 (diff) tdf#132514 DOCX import: fix lost table style with footer Bisected with: bibisect-linux64-7.0 Adding Cc: to László Németh Created attachment 174253 [details]
docum_minimized.docx: with exaggerated spacing
There are only two things that define w:spacing in docum.docx - all in styles:
<w:pPrDefault> #Document defaults - overridden by Table style
<w:pPr>
<w:spacing w:after="200" w:line="276" w:lineRule="auto"/>
</w:pPr>
</w:pPrDefault>
and
<w:style w:type="table" w:styleId="Tabellengitternetz">
<w:name w:val="Table Grid"/>
<w:pPr>
<w:spacing w:after="0" w:line="240" w:lineRule="auto"/>
</w:pPr>
So the table contents should be single spaced (not 1.15) with zero after-spacing.
This already linked bug report acted rather similarly to what we see here... commit 45504ca72e0f081de9e7cc4f1faf553c7361694d Author: László Németh on Wed Jul 1 18:14:39 2020 +0200 tdf#133735 DOCX: fix paragraph settings of nested tables proposed fix at https://gerrit.libreoffice.org/c/core/+/120526 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/33d588ab553652637e90ecd543c1ffa6301c762b related tdf#134569 writerfilter: negative means table end It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/28a7fec1f6465f8bfee417d447eb2e684ffe040b tdf#134569 writerfilter: move tableParaProps on table endLevel It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin, please mark this as resolved. I just verified and it is ok in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5b025285b3528910a4360899abb2bbbaadc72c97 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/8c099c96936f136a1f76ac76259e14416e866980 related tdf#134569 writerfilter: negative means table end It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/390d696395212721db5b050c03086fab9d667f12 tdf#134569 writerfilter: move tableParaProps on table endLevel It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |