| Summary: | Writer crashes when merging horizontally cells in a table (GTK3) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Aleksandr <dumanovsky> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | ilmari.lauhakangas, paolo.redaelli, telesto, xiscofauli |
| Priority: | medium | Keywords: | bibisectRequest, haveBacktrace, regression |
| Version: | 5.0 all versions | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=122844 https://crashreport.libreoffice.org/stats/signature/SwTableBox::GetSttIdx |
||
| Whiteboard: | target:7.1.0 target:7.0.1 target:6.4.7 | ||
| Crash report or crash signature: | ["SwTableBox::GetSttIdx"] | Regression By: | |
| Bug Depends on: | |||
| Bug Blocks: | 122043 | ||
| Attachments: |
Sample document
backtrace gdbtrace with the patch included |
||
|
Description
Aleksandr
2020-07-24 12:17:08 UTC
Created attachment 163479 [details]
Sample document
Reproduced in Version: 7.1.0.0.alpha0+ Build ID: d8270636a57e7dc68ede51308c380e2098f765d7 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded this is a regression. I tried to bisect it with bibisect-50max on linux but the output is not accurate. @Ilmari, if you have a chance, could you please try give it a try on Win ? I'm not noticing any crash.. Version: 7.1.0.0.alpha0+ (x64) Build ID: <buildversion> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Is there a screencast? No crash with Version: 7.0.0.2 Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded No repro on Win. On Linux, only gtk3 crashes. Created attachment 163882 [details]
backtrace
its an a11y issue rather than a specific gtk one as far as I can see https://gerrit.libreoffice.org/c/core/+/99956 makes what I see not crash Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9445a5633b167c84eb96c515f3ae765ab427442a tdf#135098 assert/crash on checking IsSelected on cell being disposed It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed the assert I saw to master, with backport to 7-0 in gerrit Verified, thanks! Arch Linux 64-bit Version: 7.1.0.0.alpha0+ Build ID: 94811eac3bd3077b60029c52d7798bca9b3c877b CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 2 August 2020 Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/48f48eea8a57d0da9defae77d9fc51dfe84bcfca tdf#135098 assert/crash on checking IsSelected on cell being disposed It will be available in 7.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Still crashing for me in Version: 7.1.0.0.alpha0+ Build ID: 32090b018d9ff81659a4c9ed41c64109ebebe4fc CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded (bisect repository) Created attachment 163897 [details]
gdbtrace with the patch included
The new backtrace ( SwTableBox::GetSttIdx ) seems to be the same as in bug 122844 there's only one line of bt though, but it does look similar I have high hopes that https://gerrit.libreoffice.org/c/core/+/100186 fixed this and maybe bug #122844 too (untested for that case) (In reply to Caolán McNamara from comment #18) > I have high hopes that https://gerrit.libreoffice.org/c/core/+/100186 fixed > this and maybe bug #122844 too (untested for that case) I do confirm the patch fixes the issue for me. OTOH, your previous patch < 9445a5633b167c84eb96c515f3ae765ab427442a > fixes bug 122844 for me... *** Bug 122844 has been marked as a duplicate of this bug. *** Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/818511e32f41bdf873bb660ec67bc82e4a27e847 tdf#135098 update SwTableCursor m_SelectedBoxes before merge It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. that seems to do the right thing, fixed in master and backports to 7-0 and 6-4 in gerrit Verified in Version: 7.1.0.0.alpha0+ Build ID: 6ad2f463784a24c566477cdd60ae729651bb8564 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, thanks for fixing this issue!! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/1bef764ac84d113a0bcb237a0634579ee8dccec0 tdf#135098 update SwTableCursor m_SelectedBoxes before merge It will be available in 7.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/0d5affd7a25396dbff866adae524a4c01329801f tdf#135098 update SwTableCursor m_SelectedBoxes before merge It will be available in 6.4.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |