| Summary: | Locale en-HK is not supported | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Steven Drinnan <steven> |
| Component: | Localization | Assignee: | Eike Rathke <erack> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | erack, ming.v.hua, serval2412 |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.1.0 target:7.0.3 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Steven Drinnan
2020-08-07 05:44:06 UTC
Indeed taking a look at: sc/source/filter/oox/numberformatsbuffer.cxx I noticed there's already this: English, Australia English, Belize English, Canada English, Caribbean English, United Kingdom English, Ireland English, Jamaica English, New Zealand English, Philippines English, Trinidad and English, USA English, South Africa English, Zimbabwe But nothing about English, Hong-Kong See https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/numberformatsbuffer.cxx?r=45170005#1635 In LibreOffice the way to add support for a new locale is by providing a new file in core/i18npool/source/localdata/data: https://git.libreoffice.org/core/+/refs/heads/master/i18npool/source/localedata/data/ The format is simple XML and the preparation can be done by a user without much experience in programming. And it's usually done by a user of the locale. See, for example, bug 127011. Eike is the developer responsible for this area, so I'm adding him to CC. And he'll correct anything I've missed or got wrong in the explanation above. The en-HK data can be inherited from en-GB using the ref=... mechanisms, I'll do. (In reply to Julien Nabet from comment #1) > sc/source/filter/oox/numberformatsbuffer.cxx Those are only some default presets used during import from Excel OOXML. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5dffb7ba361ad76aa249d6c93fd87fff67362726 Resolves: tdf#135518 Add English (Hong Kong) [en-HK] locale data It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ca21731d2f050d709107d1c5c1ebd59a72dc84eb Related: tdf#135518 Add English (Hong Kong) [en-HK] to language list It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. @fitojb: please do not set bugs assigned to others to resolved fixed, thanks. So we could backport the locale data to 7-0, but not the language list entry (now after UI freeze) as it would be added to translation work. The consequence would be that the locale would be listed as
{en-HK}
or if it's inherited from the system's default
Default - {en-HK}
I wouldn't mind that, but some may.. YMMV.
Pending review https://gerrit.libreoffice.org/c/core/+/103328 for 7-0 Note that in the language list this shows up as {en-HK} or Default - {en-HK} as there is, on purpose, no language list entry that would need translation. If there are concerns about this UX please object.. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/37352332a3b6e6d068ce77b46f616e0b752e3ba8 Resolves: tdf#135518 Add English (Hong Kong) [en-HK] locale data It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |