Bug 135625

Summary: Change "Drawing objects" in Calc's Navigator from a generic image to drawing object
Product: LibreOffice Reporter: Rizal Muttaqin <rizmut>
Component: UIAssignee: Rizal Muttaqin <rizmut>
Status: RESOLVED FIXED    
Severity: normal    
Priority: medium    
Version: Inherited From OOo   
Hardware: All   
OS: All   
Whiteboard: target:7.1.0 target:7.0.2
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 117497, 120946, 120949, 125965, 131141    
Attachments: "Drawing object" icon in Calc's Navigator
Writer "Drawing objects" in Navigator

Description Rizal Muttaqin 2020-08-10 23:20:13 UTC
Created attachment 164140 [details]
"Drawing object" icon in Calc's Navigator

Step to reproduce
1. Open up Calc
2. Insert a picture/image
3. Insert a shape (e.g. rectangle), right click on the shape > select Name..., type any name (e.g. "Rectangle1") to give a name and activate the "Drawing objects" in Navigator

As you can see in the screenshot the icon now uses generic image instead of drawing object (shape). Please change it. This apply to all icon themes so I guess something should be done in code.


Version: 6.4.5.2
Build ID: 1:6.4.5-0ubuntu0.18.04.1
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; 
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

Version: 7.1.0.0.alpha0+
Build ID: <buildversion>
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-03_12:22:47
Calc: threaded
Comment 1 Rizal Muttaqin 2020-08-10 23:39:14 UTC
Created attachment 164141 [details]
Writer "Drawing objects" in Navigator

Writer has a right icon
Comment 2 Rizal Muttaqin 2020-08-10 23:39:36 UTC
I should be wrong, the icon does not need to additional code/code change, just change sc/res/nc08.png, will work on this
Comment 3 Commit Notification 2020-08-12 17:34:02 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a2219391f3018c285a792c34f56a85d1af7076e9

tdf#135625 icons for Drawing Object in Calc's Navigator

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-08-13 11:23:41 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/e5f0fcd2f152233e119b7bc21af0a7d70c05226b

tdf#135625 icons for Drawing Object in Calc's Navigator

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.