| Summary: | can not unprotect bookmarks | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Sciuriware <J.F.Lanting> |
| Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | bubli, dgp-mail, michael.stahl, raal, rpr.nospam, ubayeri_q627r, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, needUITest, regression |
| Version: | 7.0.0.3 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=136960 | ||
| Whiteboard: | target:7.1.0 target:7.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 108288 | ||
| Attachments: | test file | ||
|
Description
Sciuriware
2020-08-18 12:12:57 UTC
... just moved to my wife's iMac running LibreOffice 6.4.5.2 There my documents bookmarks showed NOT protected, so I could easily delete the unwanted bookmarks there. ... It's a bug in 7. ;JOOP! I confirm it with Version: 7.0.0.3 (x64) Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: threaded Steps to reproduce 1. Add some booksmarks in a text 2. Open navigator in sidebar 3. Select bookmark => context menu => edit bookmark Result: Delete button is greyed out This seems to have begun at the below commit. Adding Cc: to Katarina Behrens ; Could you possibly take a look at this one? Thanks 62d27ef7c06dd68b34d0247b1145bad4ddc188a0 is the first bad commit commit 62d27ef7c06dd68b34d0247b1145bad4ddc188a0 Author: Jenkins Build User <tdf@pollux.tdf> Date: Mon Feb 3 23:56:26 2020 +0100 source cb5d18871b46ef4f7bc47eb4d71df5374d712575 author Katarina Behrens <Katarina.Behrens@cib.de> 2020-01-24 18:40:24 +0100 committer Michael Stahl <michael.stahl@cib.de> 2020-02-03 13:13:21 +0100 commit cb5d18871b46ef4f7bc47eb4d71df5374d712575 (patch) tree 8ea494866e1761716dcdeed6eab981ebf535ecff parent 56a89f475570d6937e8e2b9d00a72a19c2dd7665 (diff) sw: Optionally disable bookmark manipulation GUIs If the ProtectBookmarks bit is set, don't allow bookmark changes, neither via the bookmark dialog nor the navigator. Tools> Protect document > Protect bookmarks is not checked. Created attachment 165200 [details]
test file
The same situation for 7.0.1 ;JOOP! A temporary solution for the problem: to get rid of a bookmark, delete the item involved, then restore it by hand. ;JOOP! Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fefcad1186232b26180d095bbafdf8e8bdda8209 tdf#135879 sw: fix bookmark dialog's Delete button It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed on master That's fast! Thanks. ;JOOP! Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/88084ceca708a343fc79249f91eb9de34d26b3e9 tdf#135879 sw: fix bookmark dialog's Delete button It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-0-2": https://git.libreoffice.org/core/commit/6b9733e14ada8e07822f17bea32f399e1b9964c5 tdf#135879 sw: fix bookmark dialog's Delete button It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 136960 has been marked as a duplicate of this bug. *** Verified in Version: 7.1.0.0.alpha0+ Build ID: cd85546a2fbdade42f80fd3b6bd650791db9f32d CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: tr-TR (en_US.UTF-8); UI: en-US Calc: threaded @Michael Stahl, thanks for fixing this issue! Verified in 7.0.2.2, Build 8349ace3c3162073abd90d81fd06dcfb6b36b994 ;JOOP! *** Bug 137969 has been marked as a duplicate of this bug. *** |