| Summary: | Image toolbar in Calc contains an unnecessary blank area and a corresponding menu option with no text | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Steve Fanning <stevemfanning.wh> |
| Component: | Calc | Assignee: | Po-Yen Huang <jeff.huang> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | ilmari.lauhakangas, kainz.a, mentoring, momonasmon, vsfoote |
| Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillDesign, topicDesign |
| Version: | 7.0.0.2 rc | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.4.0 target:7.3.1 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 113359 | ||
| Attachments: | Screenshot showing blank menu entry | ||
|
Description
Steve Fanning
2020-09-01 10:36:28 UTC
Created attachment 164962 [details]
Screenshot showing blank menu entry
Attached screenshot of lower part of Visible Buttons menu for Calc's Image toolbar, with blank menu entry highlighted.
Confirmed Arch Linux 64-bit Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 13aaeb5d148c1ea5163eecaa176fac4a67689277 CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 7 May 2021 Code pointer: sc/uiconfig/scalc/toolbar/graphicobjectbar.xml The line is <toolbar:toolbaritem xlink:href=".uno:GraphicDialog"/> Added in https://git.libreoffice.org/core/commit/e48fc4d011f43d5d2260e4db435fa925037cbcd8 tdf#120856 sync shape, graphic, frame and ole contect toolbar (In reply to Buovjaga from comment #3) > Code pointer: sc/uiconfig/scalc/toolbar/graphicobjectbar.xml > > The line is > > <toolbar:toolbaritem xlink:href=".uno:GraphicDialog"/> > > Added in > > https://git.libreoffice.org/core/commit/ > e48fc4d011f43d5d2260e4db435fa925037cbcd8 > tdf#120856 sync shape, graphic, frame and ole contect toolbar Yes, but isn't the .uno:GraphicDialog widget (commonly <F4> shortcut) undefined in any sense for Calc other than being in the scalc/toolbar/graphicobjectbar.xml and incorrectly in a couple of the Notebook bar .UI configs? Should probably just be removed. The command uno:GraphicDialog is linked to FN_FORMAT_GRAFIC_DLGwhich has its execution function at sw/source/uibase/shells/grfsh.cxx. There is no image properties dialog other than in Writer and labels are consequently only defined for Writer in officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu In a nutshell: remove this command from other modules, code pointer in comment 3. Also check the Notebookbars. I pushed a fix on gerrit for this issue, please review it :-) https://gerrit.libreoffice.org/c/core/+/127984 Jeff Huang committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0596ef354ee8d40976c6be044a646757240f7921 tdf#136362 Remove unnecessary blank area and option in some image toolbar It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Jeff Huang committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/1a78f2b7b79e94b770f1e642cc8c1a5f5cbc3327 tdf#136362 Remove unnecessary blank area and option in some image toolbar It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |