Bug 136437

Summary:	.uno:NewRouting is named “Reset Routing” in Draw’s UI and “Reset Line Skew” in Help
Product:	LibreOffice	Reporter:	Adolfo Jayme Barrientos <fitojb>
Component:	Draw	Assignee:	Ayhan Yalçınsoy <ayhanyalcinsoy>
Status:	RESOLVED FIXED
Severity:	normal	CC:	heiko.tietze, mentoring, olivier.hallot, serval2412
Priority:	medium	Keywords:	difficultyBeginner, easyHack, skillDesign, topicUI
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:	target:7.1.0
Crash report or crash signature:		Regression By:

Description Adolfo Jayme Barrientos 2020-09-03 14:48:16 UTC

It seems like, at some point, an incomplete rename was carried out. Assuming this, can somebody investigate (ideally with historical StarOffice/OOo builds) what was the original user-facing name of the .uno:NewRouting command, when was it renamed, and/or why there is a discrepancy at all?

The name “Reset Routing” doesn’t make sense to me, and the Connector dialog makes a reference to “line skew”, so I assume this was/is the preferred name for this feature.

Relevant Help page: https://help.libreoffice.org/7.0/es/text/simpress/01/05170000.html?System=UNIX&DbPAR=DRAW&HID=cui/ui/connectortabpage/ConnectorTabPage#bm_id3150343

Comment 1 Julien Nabet 2020-09-03 15:46:25 UTC

I agree with you but just for the record, "Reset Routing" has been there since:
commit dcfa656472b5418b3734a8e59ed5066be5c11ef0
Author: Kurt Zenker <kz@openoffice.org>
Date:   Wed Feb 25 15:39:06 2004 +0000

    INTEGRATION: CWS layoutmanager (1.1.2); FILE ADDED
    2004/02/03 15:12:14 cd 1.1.2.2: #111899# Now all known languages combined into new configuration files
    2004/01/30 11:16:26 cd 1.1.2.1: #111899# Added new user interface command description files

in officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu

Comment 2 Heiko Tietze 2020-09-23 09:01:19 UTC

So let's rename the command .uno:NewRouting in officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu from "Reset Routing" to "Reset line skew".

Comment 3 Commit Notification 2020-10-05 10:00:46 UTC

Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/551796bf1ccfbb7953109f55c09011ef48315d8a

tdf#136437: .uno:NewRouting is renamed as 'Reset Line Skew'

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.