Bug 136498

Summary: In PDF options "%PRODUCTNAME" is displayed in tooltip
Product: LibreOffice Reporter: MrHeating <officialmitx>
Component: Printing and PDF exportAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: trivial CC: andreas.heinisch, caolan.mcnamara, serval2412
Priority: medium    
Version: 6.4.5.2 release   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard: target:7.2.3 target:7.3.0
Crash report or crash signature: Regression By:
Attachments: "%PRODUCTNAME" in a tootip in LibreOffice v6.4.5.2
PDF Options

Description MrHeating 2020-09-05 14:49:55 UTC 
Created attachment 165182 [details]
"%PRODUCTNAME" in a tootip in LibreOffice v6.4.5.2

Prompted by the according - https://wiki.documentfoundation.org/Faq/Writer/PDF_Hybrid - startup tip, in File → Export As → Export as PDF → General → Hybrid PDF,

the tooltip to "Hybrid PDF (embed ODF file)" reads

"Creates a PDF that is easily editable in %PRODUCTNAME"

This is the only instance as far as I found.
Comment 1 Julien Nabet 2020-09-05 18:04:37 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 2 Julien Nabet 2020-09-05 19:26:11 UTC 
@devs: shouldn't all %PRODUCTNAME placeholders be taken into account by ./sysui/desktop/share/brand.pl ?
Comment 3 Andreas Heinisch 2021-10-14 20:18:49 UTC 
Created attachment 175746 [details]
PDF Options

Cannot reproduce the error in:

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8fb366c13ac1b23c455c32afc085bca2edff03bb
CPU threads: 6; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-US
Calc: CL
Comment 4 Julien Nabet 2021-10-17 12:01:43 UTC 
On pc Debian x86-64 with master sources updated today, I don't reproduce this with kf5 and gen renderings but could reproduce this with gtk3 rendering.

Caolán: thought you might be interested in this one.
Comment 5 Julien Nabet 2021-10-17 12:28:04 UTC 
Perhaps a similar patch as https://cgit.freedesktop.org/libreoffice/core/commit/?id=c9b19f69e658f1114f1b8fc0ae62b6edd6d33e3f
"Resolves: tdf#142704 %PRODUCTNAME shown in gtk3 extended tips"
should be used?
Comment 6 Commit Notification 2021-10-19 09:19:16 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/a928c968dc21d7e73172ebd6a55c4f4fae5a992d

Resolves: tdf#136498 %PRODUCTNAME shown in tool tips

It will be available in 7.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-10-19 09:38:03 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f5dbf927bf44c9a1ac80eae6f72887a4f3543201

Resolves: tdf#136498 %PRODUCTNAME shown in tool tips

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Julien Nabet 2021-10-20 18:51:58 UTC 
On pc Debian x86-64 with master sources updated today, I confirm I don't reproduce the bug.
Thank you Caolán!