| Summary: | [EDITING] "Replace All" does not undo properly if the replacement string is empty | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Matt McCutchen <matt> |
| Component: | Writer | Assignee: | Michael Stahl (allotropia) <michael.stahl> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | barakso.attila, michael.stahl, telesto, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 6.4.6.2 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=131912 | ||
| Whiteboard: | target:7.1.0 target:7.0.3 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Matt McCutchen
2020-09-08 17:45:16 UTC
*** Bug 136580 has been marked as a duplicate of this bug. *** Version: 7.1.0.0.alpha0+ (x64) Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Bibisected using bibisect-win64-7.1 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e1629c210ad78310e3d48c0756723134a27b89df author: Michael Stahl <Michael.Stahl@cib.de> committer: Michael Stahl <Michael.Stahl@cib.de> summary: tdf#131912 sw: fix spell check correct deleting flys Adding CC: Michael Stahl Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d3eca4177a78c3db17b4699ea6e071e52488c46f tdf#136577 sw: fix Undo of Replace with nothing It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed on master Thanks Michael! I felt bad for you with your sequence of commits, each of which caused a regression that had to be fixed by the next one, which doesn't surprise me with this staggeringly complex codebase. I'm glad this fix was so simple; hopefully it will be the last of this particular sequence. :) I imagine you've already tested the code, but FWIW, I'll test the nightly build with the fix when it comes out. I should add, thanks to everyone who helped triage the issue too. Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/ba5584a3ce86c2db52e2e4a4b91254741b2616ec tdf#136577 sw: fix Undo of Replace with nothing It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c064766901722082df0d759c95434c1460fcdba5 tdf#136577: sw: Add UItest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 7.1.0.0.alpha0+ Build ID: e897fdc46b07f211c4c96de103cfa494b645035a CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Michael Stahl, thanks for fixing this issue!! I verified the fix too in master~2020-10-19_17.49.49_LibreOfficeDev_7.1.0.0.alpha0_Linux_x86-64_rpm.tar.gz . |