Bug 136588

Summary: FILEOPEN: DOCX: incorrect line break
Product: LibreOffice Reporter: Xisco Faulí <xiscofauli>
Component: WriterAssignee: Attila Bakos (NISZ) <bakos.attilakaroly>
Status: VERIFIED FIXED    
Severity: normal CC: bakos.attilakaroly, libreoffice, telesto, xiscofauli
Priority: medium Keywords: bibisected, bisected, regression
Version: 7.1.0.0.alpha0+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=112290
Whiteboard: target:7.1.0
Crash report or crash signature: Regression By:
Attachments: Comparison MSO 2010 and LibreOffice 7.1 master
How it looks after the patch in 7.1 master

Description Xisco Faulí 2020-09-08 21:32:56 UTC
Created attachment 165298 [details]
Comparison MSO 2010 and LibreOffice 7.1 master

Steps to reproduce:
1. Open attachment 90936 [details] from bug 72838 and check page 1

-> line 2 and 3 have incorrect line break. see screenshot

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 6b2eff7d69c6e14d89dd33eaa58c01d82c541266
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-09-08 21:34:21 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1b03a449161af225302e4b4dd2bb2e69c6d8d170

author	Attila Bakos <bakos.attilakaroly@nisz.hu>	2020-08-03 10:45:14 +0200
committer	László Németh <nemeth@numbertext.org>	2020-08-19 10:11:21 +0200
commit 1b03a449161af225302e4b4dd2bb2e69c6d8d170 (patch)
tree b3d274ccb3ab93824c2b29e11583e071a77f5cac
parent 8d1aaca8fea5b2330a2019b64188e66223cb35e3 (diff)
tdf#112290 sw: fix missing line break in small capital

Bisected with: bibisect-linux64-7.1

Adding Cc: to Attila Bakos
Comment 2 Xisco Faulí 2020-09-08 21:49:43 UTC
attachment 101260 [details] from bug 76569 is also affected by this issue
Comment 3 Xisco Faulí 2020-09-08 21:54:46 UTC
and attachment 96556 [details] from bug 76747
Comment 4 Commit Notification 2020-09-24 11:55:04 UTC
Attila Bakos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d28097fadf44ed58cb5e3e9b9c04a65a7a33fd6

tdf#136588 sw: fix line break regression with small caps

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Attila Bakos (NISZ) 2020-09-25 09:17:48 UTC
Created attachment 165827 [details]
How it looks after the patch in 7.1 master

Works for me, setting to fixed.
Comment 6 NISZ LibreOffice Team 2020-09-28 08:10:40 UTC
*** Bug 136677 has been marked as a duplicate of this bug. ***
Comment 7 Xisco Faulí 2020-09-28 14:40:27 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 050e95e50d44a5cbb74bb5de481cb30551f83136
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Attila Bakos, thanks for fixing this issue!!