| Summary: | Text in LO brand logo rendered ugly when anti-aliasing is disabled | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Ming Hua <ming.v.hua> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | ||
| Severity: | minor | CC: | glogow, heiko.tietze, quikee, vsfoote, xordevoreaux |
| Priority: | medium | Keywords: | needsDevAdvice |
| Version: | 7.0.0.3 release | ||
| Hardware: | All | ||
| OS: | Windows (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=139085 | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103202 | ||
| Attachments: | Screenshot of the "About LibreOffice" dialog | ||
|
Description
Ming Hua
2020-09-10 04:42:07 UTC
Both the brand image as well as the logo are SVGs now. And vectors draw badly without anti-aliasing. Don't see what we can do to improve this (expect moving back to PNG using two versions for low and hi-res screens). *** Bug 143545 has been marked as a duplicate of this bug. *** Isn't the SVG for imBrand being converted from SVG to bitmap? And then has to be down sampled to fit scaling of the StartCenter or the Help About dialog? Opening the SVG directly external to LibreOffice-- logo.svg opens at 600 x 115 px, while logo-sc.svg (for the StartCenter) opens at 600 x 124 px (bcz it needs extra height for the descender of the y in Community). =-ref-= https://opengrok.libreoffice.org/xref/core/sfx2/source/appl/appmisc.cxx?r=107399d6&fi=loadBrandSvg#127 (In reply to V Stuart Foote from comment #3) > =-ref-= > > https://opengrok.libreoffice.org/xref/core/sfx2/source/appl/appmisc. > cxx?r=107399d6&fi=loadBrandSvg#127 And for the BackingWindow for the StartCenter, same loadBrandSvg for the logo-sc.svg and the SVG is being converted and scaled. Quality of the downsampling/scaling is causing the bad rendering in the UI. =-ref-= https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/about.cxx?r=427deae2#92 https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/about.cxx?r=14cfff50 93 const tools::Long nWidth(m_pCopyrightLabel->get_preferred_size().getWidth()); 94 BitmapEx aBackgroundBitmap; 96 if (SfxApplication::loadBrandSvg(Application::GetSettings() 97 .GetStyleSettings() 98 .GetDialogColor() 99 .IsDark() 100 ? "shell/logo_inverted" 101 : "shell/logo", 102 aBackgroundBitmap, nWidth * 0.8)) { 103 ScopedVclPtr<VirtualDevice> m_pVirDev = 104 m_pBrandImage->create_virtual_device(); 105 m_pVirDev->SetOutputSizePixel(aBackgroundBitmap.GetSizePixel()); 106 m_pVirDev->DrawBitmapEx(Point(0, 0), aBackgroundBitmap); 107 m_pBrandImage->set_image(m_pVirDev.get()); 108 m_pVirDev.disposeAndClear(); It says: Load the SVG and size it to 80% of the length of the copyright text. Then draw this image exactly as it to the provided image canvas. For me on Linux it's crisp with or without antialiasing. Repro: Version: 7.1.0.0.alpha1+ (x64) Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: en-US Calc: CL Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community Build ID: ff2ba77f22b2e96f96f5537aec1705956b47583d CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: en-US Calc: CL Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 2b0b4ddc8bd8fdd4cd689300620fe4621d7533b7 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded |