Bug 137039

Summary:	No line wrapping for long checkbox entry in options
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	UI	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caolan.mcnamara, heiko.tietze, samuel.mehrbrodt
Priority:	medium
Version:	7.1.0.0.alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=127537
Whiteboard:	target:7.1.0
Crash report or crash signature:		Regression By:
Attachments:	Situation with generic VCL (working as expected) gtk version gen version Screenshot text crossing dialog border

Description Telesto 2020-09-26 08:56:31 UTC

Description:
UI: When encrypting documents, always encrypt to self is cut off in German User Interface Language

Steps to Reproduce:
1. Open LibreOffice (set language in tools options to German)
2. Tools Options-> User Data tab

Actual Results:
When encrypting documents, always encrypt to self doesn't fit

Expected Results:
Should fit, break the line?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 52a49f9e480ca03e231cfda82640a928393131c9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Comment 1 Telesto 2020-09-27 07:56:51 UTC

@Heiko 
Who is 'responsible' here. Is this an translation issue? Should the line be broken of they dialog being larger?

Comment 2 Heiko Tietze 2020-09-28 07:55:20 UTC

The line is properly wrapped with kf5 and gen VCLs. So the issue is gtk3 and maybe the same as in bug 127537 (but hard to believe this checkbox label is selectable). The master of gtk is Caolan.

Comment 3 Heiko Tietze 2020-09-28 07:56:43 UTC

Created attachment 165904 [details]
Situation with generic VCL (working as expected)

Issue is the last checkbox "Wenn Dokumente verschlüsselt werden..."

Comment 4 Caolán McNamara 2020-09-28 08:24:23 UTC

Created attachment 165905 [details]
gtk version

gtk one looks ok

Comment 5 Caolán McNamara 2020-09-28 08:24:48 UTC

Created attachment 165906 [details]
gen version

gen version also seems ok

Comment 6 Telesto 2020-09-28 09:20:59 UTC

Created attachment 165912 [details]
Screenshot text crossing dialog border

Comment 7 Caolán McNamara 2020-09-28 14:40:57 UTC

The title seems bogus in that the screenshot with the problem isn't gtk3 but the win case which *should* be the same as the gen case

Comment 8 Caolán McNamara 2020-09-28 15:02:35 UTC

well, there is about 6 hectares of white space to the left going to waste. I say we just move it left into that available space and be done with it

Comment 9 Commit Notification 2020-09-28 19:09:25 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/443ca9d5c4d29a8efbea9f907fe473346acd6701

tdf#137039 move the super long checkbox into the available whitespace

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 10 Heiko Tietze 2020-09-29 07:07:59 UTC

(In reply to Caolán McNamara from comment #8)
> well, there is about 6 hectares of white space to the left...

With the indentation the checkbox belongs to the option above, removing the large white-space changes this and makes the checkbox an independent option. Whether or not this is correct, the actual bug is line wrapping (no idea if this is limited to gtk3 or win/gen).