| Summary: | XLSX: Error 507 when opened with Turkish locale | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Yusuf Keten <ketenyusuf> |
| Component: | Calc | Assignee: | Eike Rathke <erack> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | erack, libreoffice, xiscofauli |
| Priority: | medium | ||
| Version: | 6.0 all versions | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=138432 | ||
| Whiteboard: | target:7.1.0 target:7.0.3 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 137805 | ||
| Attachments: |
error507-TR-locale
no-error-507-EN-locale Error507 The example file in Excel 13 and LO7.1 nightly |
||
|
Description
Yusuf Keten
2020-09-28 09:17:34 UTC
Created attachment 165909 [details]
error507-TR-locale
Created attachment 165910 [details]
no-error-507-EN-locale
Created attachment 165911 [details]
Error507
Note that the [#this row] table reference part is displayed all lower case, which indicates an unrecognized keyword there; editing the formula (appending and removing blank and Enter) compiles it again, after which it works and the table reference part displays [#This Row]. My first guess is that on the initial import a [#This Row] of the original formula is upper cased and compared against an upper case [#THIS ROW] but that somehow happens in a tr-TR locale where it results in [#THİS ROW] (note upper case letter İ with dot above) so does not match [#THIS ROW]. A recompile of the formula expression then uses the correct en-US locale to compare keywords. Created attachment 165919 [details] The example file in Excel 13 and LO7.1 nightly No repro in: Version: 7.1.0.0.alpha0+ (x64) Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: tr-TR Calc: CL But repro in: Version: 7.1.0.0.alpha0+ (x64) Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: tr-TR (hu_HU); UI: tr-TR Calc: CL Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3c6177be2705303044e3de262689d593f3d0f282 Resolves: tdf#137091 Use CharClass matching the formula language It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d41c45a522c5e973d7043d36bc6c82e77735ab9b Current sytem locale's CharClass for user defined names, tdf#137091 follow-up It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Issue reproduced back to Version: 5.4.0.0.alpha1+ Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3; Locale: tr-TR (en_US.UTF-8); Calc: group Verified in Version: 7.1.0.0.alpha0+ Build ID: cd85546a2fbdade42f80fd3b6bd650791db9f32d CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: tr-TR (en_US.UTF-8); UI: en-US Calc: threaded @Eike, thanks for fixing this issue!! Eike Rathke committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1acf517906b7cdc4931dd26319d467dff53ae7d2 Determine CharClass difference once, tdf#137091 follow-up It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Pending review https://gerrit.libreoffice.org/c/core/+/103598 for 7-0 Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7672ac2e8764d9e4fcb5a896ef6210077907dcd0 tdf#137091: sc_subsequent_filters_test: Add unittest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/30d3ae0268290e6244e58c78b8f45ae7373c47ea Resolves: tdf#137091 Use CharClass matching the formula language It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/91de839547719b7177518386f9b39bd9e4b1cf73 tdf#137091: sc_subsequent_filters_test: Add unittest It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |