Bug 137345

Summary: Transition duration time is set in milliseconds instead of seconds
Product: LibreOffice Reporter: Telesto <telesto>
Component: ImpressAssignee: Caolán McNamara <caolan.mcnamara>
Status: RESOLVED FIXED    
Severity: normal CC: caolan.mcnamara
Priority: medium    
Version: 7.1.0.0.alpha0+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=137346
Whiteboard: target:7.1.0 target:7.0.3
Crash report or crash signature: Regression By:

Description Telesto 2020-10-08 20:11:03 UTC 
Description:
Transition duration time is set in milliseconds instead of seconds

Steps to Reproduce:
1. open Impress
2. Transition sidebar panel
3. Scroll the duration up (or use the buttons)

Actual Results:
Steps in milliseconds

Expected Results:
Steps in seconds


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
Version: 7.0.0.0.beta1+ (x64)
Build ID: 2891e91a513520d68ea2b8c59c14335861a15253
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Different dialog in 6.4
Comment 1 Telesto 2020-10-08 20:12:39 UTC 
@Caolan
As you mostly do dialog issues. Can be bibisected if needed, but not seeing the point here.
Comment 2 Telesto 2020-10-08 20:20:41 UTC 
(In reply to Telesto from comment #1)
> @Caolan
> As you mostly do dialog issues. Can be bibisected if needed, but not seeing
> the point here.

Would be nice if you could do bug 137346 along the ride; closely related (already present for a while)
Comment 3 Commit Notification 2020-10-12 13:29:14 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/43365359a817c85d6d7e138b1cc773352ebb6e07

Resolves: tdf#137345 increment by a full second on up/down

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2020-10-12 13:29:52 UTC 
done in master, backport to 7-0 in gerrit
Comment 5 Commit Notification 2020-10-13 09:26:31 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/4ee6b9857d651d4bc7667227de4381286f3a9233

Resolves: tdf#137345 increment by a full second on up/down

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.