Bug 137369

Summary: Some links.txt target point to nonexistent icons
Product: LibreOffice Reporter: Paul Kepinski <paul.kepinski>
Component: LibreOfficeAssignee: Rizal Muttaqin <rizmut>
Status: RESOLVED FIXED    
Severity: normal CC: kainz.a, paul.kepinski, rizmut, xiscofauli
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard: target:7.1.0 target:7.0.3
Crash report or crash signature: Regression By:
Attachments: Check links script

Description Paul Kepinski 2020-10-09 10:53:08 UTC 
Description:
Similar to this issue here with Yaru icons: https://github.com/ubuntu/libreoffice-style-yaru-fullcolor/issues/138

I created a script for checking Yaru's links.txt and I noticed similar problem with Colibre's one.

Because of my very bad internet connection I've only tested the Colibre icon pack with rizmut Github repo so you should also check the other icon pack.


Actual Results:
Some target links points to nonexistent file.

Expected Results:
Target links should points to real icon file.


Reproducible: Always


User Profile Reset: No



Additional Info:
Here is the return of the adapted script:

$ ./check-links.sh 

=> ⏳ Checking links.txt - please wait

Error line 1087: target file /cmd/32/showtoolbar.png not found
Error line 1089: target file /cmd/32/showtoolbar.png not found
Error line 1090: target file /cmd/lc_showtoolbar.png not found
Error line 1092: target file /cmd/lc_showtoolbar.png not found
Error line 1093: target file /cmd/sc_showtoolbar.png not found
Error line 1095: target file /cmd/sc_showtoolbar.png not found
Error line 1736: target file /res/printeradmin_16.png not found
Error line 1737: target file /res/printeradmin_32.png not found
Error line 1961: target file /cmd/color.png not found
Error line 2163: target file /cmd/32/badcellstyles.png not found
Error line 2166: target file /cmd/32/goodcellstyles.png not found
Error line 2169: target file /cmd/32/neutralcellstyles.png not found
Error line 2171: target file /cmd/lc_badcellstyles.png not found
Error line 2174: target file /cmd/lc_goodcellstyles.png not found
Error line 2177: target file /cmd/lc_neutralcellstyles.png not found
Error line 2220: target file /cmd/32/insertfixedtext.png not found
Error line 2222: target file /cmd/lc_insertfixedtext.png not found
Error line 2224: target file /cmd/sc_insertfixedtext.png not found

=> 18 error(s) found
Comment 1 Paul Kepinski 2020-10-09 10:54:49 UTC 
Created attachment 166235 [details]
Check links script

Just put this check script in the same directory as links.txt file and execute it.
Comment 2 Roman Kuznetsov 2020-10-10 16:07:29 UTC 
Rizal, Andreas, I thought it's your theme
Comment 3 Commit Notification 2020-10-13 03:43:51 UTC 
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4f8b13267559e8e89a306a6c522f905322396bd0

tdf#137369 Add missing targeted icons as defined by links.txt

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-10-13 04:35:21 UTC 
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/9fa90a80c6aafe894bb3cdd5fdfacc254d0df6b6

tdf#137369 Add missing targeted icons as defined by links.txt

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Adolfo Jayme Barrientos 2020-10-14 00:00:26 UTC 
Just a note, printer admin icons should no longer be required since that was removed back in 2014; see core commit a547f865e0ce7731e1b3998b06ecba505e1c27ca