Bug 137446

Summary:	resize of horizontal line via dialog in Calc introduces faulty 180deg rotation
Product:	LibreOffice	Reporter:	Regina Henschel <rb.henschel>
Component:	Calc	Assignee:	Regina Henschel <rb.henschel>
Status:	VERIFIED FIXED
Severity:	normal	CC:	xiscofauli
Priority:	medium
Version:	5.1.6.2 release
Hardware:	x86-64 (AMD64)
OS:	All
Whiteboard:	target:7.1.0 target:7.0.3
Crash report or crash signature:		Regression By:

Description Regina Henschel 2020-10-13 11:56:14 UTC

Start Calc.
Draw a horizontal line. Press shift while drag-creating to be sure the line is horizontal.
Open the "Position and Size" dialog. Make sure, the rotation is 0°.
Go to tab "Position and Size", enter a new value in the "Width" field. Press Enter.
Reopen the dialog and go to tab "Rotation". Notice that the rotation is now 180°.

In most cases this error is not visible, because lines are drawn based on their start and end points. But for lines with anchor type "To cell (resize with cell)" the wrong rotation produces wrong anchors, which results in wrong cell addresses in file.

Comment 1 Commit Notification 2020-10-13 21:02:00 UTC

Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/94e6e140491de31c0788c91af855a75a3bb12709

tdf#137446 catch divByZero in ResizeMultMarkedObj

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 2 Kevin Suo 2020-10-14 02:13:07 UTC

Confirm fixed in
Version: 7.1.0.0.alpha0+
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Calc: threaded

Comment 3 Commit Notification 2020-10-14 12:30:40 UTC

Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/f4e4c380c8aa89cedca5ab2aa2006e12461158a7

tdf#137446 catch divByZero in ResizeMultMarkedObj

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Commit Notification 2020-10-14 14:36:29 UTC

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f4f67aa5f1e062ee4376a28293cad15a154bfb5b

tdf#137446: sc: Add UItest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.