Bug 137814

Summary:	UI: Rename Properties to 'Page Properties' and 'Slide' to Slide Properties
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	Impress	Assignee:	Ayhan Yalçınsoy <ayhanyalcinsoy>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	heiko.tietze, mentoring
Priority:	medium	Keywords:	difficultyBeginner, easyHack, skillDesign, topicDesign
Version:	7.1.0.0.alpha0+
Hardware:	All
OS:	All
Whiteboard:	target:7.1.0
Crash report or crash signature:		Regression By:

Description Telesto 2020-10-28 08:25:00 UTC

Description:
Must it be 'Properties'. "Page Properties" and "Slide Properties" would be bit clearer. Yes, it's might be obvious. However keep in mind you 'don't add' Page or Slide before all of the items in the menu. So pretty inconsistent. And doesn't affect the size of the menu. And not saying harm done by a possible repeat.

Also but forward in bug 137712 (but to make sure this doesn't get lost)

Steps to Reproduce:
1. open Draw
2. Expand page menu -> Notice 'Properties'

Actual Results:
Shows properties

Expected Results:
Page properties


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Comment 1 Heiko Tietze 2020-10-28 10:35:03 UTC

Yes, Page Properties in Draw, Slide Properties in Impress.

In case of Impress, the menu entry in sd/uiconfig/simpress/popupmenu/page.xml is .uno:SlideSetup and for Draw it's sd/uiconfig/sdraw/popupmenu/page.xml .uno:PageSetup. Both UNO commands are defined in officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu with separate labels.

Comment 2 Buovjaga 2020-10-31 06:41:16 UTC

Please also remember to Update the Help files. If you are not comfortable with git submodules yet, you can edit directly on the web: https://gerrit.libreoffice.org/Documentation/user-inline-edit.html

Comment 3 Telesto 2020-11-01 11:06:57 UTC

@Heiko
Heiko Tietze
Oct 30
I wonder if we can/should change this into "slide". What do you think?

Ayhan Yalçınsoy
Oct 30
The dialog opens via Page>Properties>Page Properties menu. Because of this, I think it should be remain as Page.

----
This topic is comment 0. If you don't want 'properties' it should be Slide/Page indeed. 

Still more inclined to 'properties' however (as argued in comment 0). And Dialog called 'Slide' or 'Page' Is not saying what it does. Properties is useful IMHO

Except if Properties makes a mess of they menu size (not sure how it translates in different languages). If it would make they menu exceptional width in certain cases or so

Comment 4 Heiko Tietze 2020-11-01 11:14:47 UTC

(In reply to Telesto from comment #3)
> Except if Properties makes a mess of they menu size (not sure how it
> translates in different languages). If it would make they menu exceptional
> width in certain cases or so

Ayhan's patch changes the command to Page Properties. I'd leave it to him whether this should be Page or Slide.

Comment 5 Commit Notification 2020-11-03 08:16:51 UTC

Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/421593c0d99e04c0f9431b5ef04bc03d2053ca23

tdf#137814: Rename Properties to Page/Slide Properties

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.