Bug 138232

Summary: UI: Find all highlights even the text inside find toolbar
Product: LibreOffice Reporter: Telesto <telesto>
Component: UIAssignee: Caolán McNamara <caolan.mcnamara>
Status: VERIFIED FIXED    
Severity: normal CC: barakso.attila, caolan.mcnamara
Priority: medium Keywords: bibisected, bisected, regression
Version: 7.1.0.0.alpha1+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=136941
https://bugs.documentfoundation.org/show_bug.cgi?id=138281
Whiteboard: target:7.1.0
Crash report or crash signature: Regression By:

Description Telesto 2020-11-15 11:06:35 UTC 
Description:
Find all highlights even the text inside find toolbar

Steps to Reproduce:
1. Open Writer
2. Type: Hello ; Enter : Hello
3. CTRL+F
4. Type Hello
5. Press Enter -> Notice text not being higlighted
6. Click with they mouse on Find All (text in search bar highlighted to)

Actual Results:
Text in search bar highlighted

Not I don't think it's actually highlighting because of find all (like more focus issue)

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha1+ (x64)
Build ID: 5a96093f0ecee53432bdf35f247edd6deb501baf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-11-15 11:07:17 UTC 
Still OK IN
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL
Comment 2 Attila Baraksó (NISZ) 2020-11-16 10:10:46 UTC 
Reproduced in:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: 631974dd958fe4ca1d1f2164266e1e2c81b325ce
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded
Comment 3 Attila Baraksó (NISZ) 2020-11-16 10:15:26 UTC 
Bibisected using bibisect-win64-7.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit?id=a8c218a52a639b0e7f689dea878a0421702628e0
author: Caolán McNamara <caolanm@redhat.com>	
committer: Caolán McNamara <caolanm@redhat.com>	
summary: tdf#136941 call focus in handler explicitly
Comment 4 Attila Baraksó (NISZ) 2020-11-16 10:16:46 UTC 
Adding Cc: Caolán McNamara

Could you please check this issue too? Thanks a lot!
Comment 5 Commit Notification 2020-11-16 20:19:58 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/54fd77a368208cc759024c05b7f1df7eb85d294e

tdf#138232 don't grab focus if we already have it

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Attila Baraksó (NISZ) 2020-11-17 08:57:51 UTC 
Verified in:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: 312a33b7636334f6ce3b6d1702bc5d3e45215601
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL

@Caolán: Thanks for fixing this issue!
Comment 7 Commit Notification 2020-11-17 16:49:14 UTC 
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5e06a0809ed8f2f9fe9bc9d9720b8096e4572f5d

tdf#138232: sw: Add UItest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.