Bug 138524

Summary: Crash: Change User Interface mode on inserted OLE object.
Product: LibreOffice Reporter: sawakaze <souichirho>
Component: CalcAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: aron.budea, kainz.a, serval2412
Priority: medium    
Version: 7.1.0.0.beta1+   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107237    
Attachments: ScreenCast
bt with debug symbols

Description sawakaze 2020-11-27 11:39:51 UTC 
Description:
after following steps, libreoffice was crashed.
if my description is uncleared, please see screencast.

Steps to Reproduce:
1. Open Calc
2. menu -> View -> User interface..
-> launch "Selecy You Preferred User Interface" dialog
3. UI variant -> Tabbed
4. press "Apply to All"
5. press close 
-> close dialog
6. press Insert tab and OLE Object
7. Select Presentation
-> insert presentation
8. menu -> User interface...
9. set UI variants to "sidebar" ,press Apply to All and close.
10. click any cell
-> application crash.
 

Actual Results:
application crash.
after this crash, when open impress, impress is crashed.
On step.6, Impress UI was not TabUI

Expected Results:
Not crash


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I confirm this version

Version: 7.1.0.0.beta1
Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (C); UI: en-US
Calc: threaded

----
I downloaded from 
https://dev-builds.libreoffice.org/pre-releases/deb/x86_64/
----

OS :Linux Ubuntu MATE
Desktop Env: MATE
Comment 1 sawakaze 2020-11-27 11:41:10 UTC 
Created attachment 167617 [details]
ScreenCast

if my report is uncleared, please see screencast
Comment 2 Julien Nabet 2020-11-27 17:41:47 UTC 
Created attachment 167623 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I got a crash but not exactly at the same time.
Comment 3 Julien Nabet 2020-11-28 12:46:54 UTC 
After some debugging, the root cause is in sfx2/source/notebookbar/SfxNotebookBar.cxx here:
OUString sFile = lcl_getNotebookbarFileName( eApp );
See https://opengrok.libreoffice.org/xref/core/sfx2/source/notebookbar/SfxNotebookBar.cxx?r=d5552b8b#345
    345         OUString sFile = lcl_getNotebookbarFileName( eApp );
=> sFile = "Sidebar"
    346         OUString sNewFile = rUIFile + sFile;
=> sNewFile=modules/simpress/ui/Sidebar
    347         OUString sCurrentFile;
    348         VclPtr<NotebookBar> pNotebookBar = pSysWindow->GetNotebookBar();
    349         if ( pNotebookBar )
    350             sCurrentFile = pNotebookBar->GetUIFilePath();
=> sCurrentFile=modules/scalc/ui/notebookbar.ui
    351 
    352         bool bChangedFile = sNewFile != sCurrentFile;
=> bChangedFile = true
    353 
    354         if ((!sFile.isEmpty() && bChangedFile) || !pNotebookBar || !pNotebookBar->IsVisible()
    355             || bReloadNotebookbar || comphelper::LibreOfficeKit::isActive())
    356         {
...
    372             OUString aBuf = rUIFile + sFile;
=> aBuf=modules/simpress/ui/Sidebar (why not reusing sNewFile?)
...
    390             pSysWindow->SetNotebookBar(aBuf, xFrame, aNotebookBarAddonsItem , bReloadNotebookbar);
=> crash because SetNotebookBar expects a ui file

However not sure what's the right thing to do, return false after line 345 is sFile doesn't start with notebookbar (since there are several ui files:
notebookbar.ui, notebookbar_compact.ui, notebookbar_groupedbar_full.ui, etc.)?

Andreas: any thoughts here?
Comment 4 Sophie Sipasseuth 2023-07-20 08:28:24 UTC 
Repro with the repository win64-7.2, with LO 7.1.0 on Windows 10.
But, LO crashes in this way, it closes itself.

Idem with these versions of LO:

Version: 7.2.8.0.0+ (x64) / LibreOffice Community
Build ID: ffa09959edd087794b1f2fe6b9b6faac484ef74b
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL

Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 229123ccc6f90ebf66b3e659bebbd53f8a9bdd3a
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL

Version: 7.4.8.0.0+ (x64) / LibreOffice Community
Build ID: f8ba7c6f77497e2dc7bfef8378511e2074ce01f9
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1c629ca0048670db4bed5e7d8d76bcf8e81f2158
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL threaded

Version: 7.6.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 1b5cee822e0bc15ddbdfc86926678ca35ab3e082
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: CL threaded
Comment 5 Tex2002ans 2024-02-16 21:46:11 UTC 
Yep, can still confirm crash:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Followed comment 0 exactly (or easier, the video in comment 1).

- - -

Note: Also noticed after I got back into LibreOffice and pressed:

- View > User Interface

the radio button was on "Sidebar", even though the UI itself was all in "Single Toolbar" mode. So I:

- Pressed "Single Toolbar"
- Clicked "Apply All"

and it corrected itself back to normal.