| Summary: | Applying Formatting Aids twice crashes the application | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Heiko Tietze <heiko.tietze> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | caolan.mcnamara, ilmari.lauhakangas, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, regression |
| Version: | 7.2.0.0.alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=137930 | ||
| Whiteboard: | target:7.1.0.0.beta2 target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
Version: 7.2.0.0.alpha0+ Build ID: 3b594e1e50bdc2ad374321fa3da304596bb15ffa CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5|gtk3|gen Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded I repro on Win. Not yet in latest commit of Linux 7.1 repo (24 Nov). Version: 7.2.0.0.alpha0+ (x64) Build ID: f7e2f5bca938aa916830e07895d2da6820282055 CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=75bada928cf08d2afc6efe52ba99b45088bc9eec author Caolán McNamara <caolanm@redhat.com> 2020-11-16 15:54:04 +0000 committer Caolán McNamara <caolanm@redhat.com> 2020-11-17 09:55:03 +0100 commit 75bada928cf08d2afc6efe52ba99b45088bc9eec (patch) tree d1cf8f5c57394231bf89232fa0e24372e6da9cdd parent f98735583a666e0f06d018cf93b79c74b7ce7b80 (diff) tdf#137930 Apply button changes values to previous ones Bisected with: bibisect-linux64-7.1 Adding Cc: to Caolán McNamara formatting aids rather than writing aids I assume (In reply to Caolán McNamara from comment #4) > formatting aids rather than writing aids I assume Sure ;-) (In reply to Caolán McNamara from comment #4) > formatting aids rather than writing aids I assume Crashes with either one, I originally tested language settings - writing aids. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/62c0d42e179476da5fcad02722a9d3c6f83ef258 tdf#138596 don't destroy SfxItemSet that are still in use It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0eb6ad223272325278d52e21d4fb257025d3b54c tdf#138596 don't destroy SfxItemSet that are still in use It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. that seems to work Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf61ce8bc95ba0bc27070b503360dc5ac7a204b3 tdf#138596: sw: Add UItest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks, Caolan! |
In Tools > Options > Writer > Writing Aids, with or without change to the settings, applying the first time works well but the second time crashes the app. It's caused by sw/source/ui/config/optpage.cxx const SwDocDisplayItem* pOldAttr = static_cast<const SwDocDisplayItem*>( GetOldItem(GetItemSet(), FN_PARAM_DOCDISP)); where the old itemset is NULL.