| Summary: | "Apply to All" button in select preferred UI dialog can't be translated | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Ming Hua <ming.v.hua> |
| Component: | UI | Assignee: | Heiko Tietze <heiko.tietze> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | heiko.tietze |
| Priority: | medium | ||
| Version: | 7.1.0.0.beta1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.2.0 target:7.1.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 117463 | ||
| Attachments: | Screenshot with KeyID (qtz) UI | ||
|
Description
Ming Hua
2020-12-02 23:13:12 UTC
The "Apply to %MODULE" next to it has also no translation flag. Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b866b0da4007df19a17c42f56ca11e0e277ce4d2 Resolves tdf#138631 - Make 'Apply to All' translatable It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks for the quick fix, Heiko! (In reply to Heiko Tietze from comment #1) > The "Apply to %MODULE" next to it has also no translation flag. True, however as you can see in my screenshot, it had already been i18n'ed and was translatable before this commit. It seems the string used by the UI is not the one defined in the toolbarmodedialog.ui file, but rather "RID_SVXSTR_UI_APPLYALL" defined in cui/inc/strings.hrc [1] and used in cui/source/dialogs/toolbarmodedlg.cxx [2]. 1. https://opengrok.libreoffice.org/xref/core/cui/inc/strings.hrc#401 2. https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/toolbarmodedlg.cxx#115 Heiko Tietze committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/a6ea4f4b5d34b634f0c1743def507ac248bfc2e9 Resolves tdf#138631 - Make 'Apply to All' translatable It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |