| Summary: | FORMCONTROLS: Date in formatted fields is set back to number when saving control properties | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Robert Großkopf <robert> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | aron.budea, caolan.mcnamara, serval2412, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.0.3.1 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=138271 | ||
| Whiteboard: | target:7.1.0.0.beta2 target:7.2.0 target:7.0.5 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
Robert Großkopf
2020-12-04 17:48:38 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this (at least the beginning since I stopped then). I noticed these logs: warn:comphelper:59591:59591:comphelper/source/misc/numbers.cxx:44: getNumberFormatType : invalid key! (maybe created with another formatter ?) warn:legacy.tools:59591:59591:extensions/source/propctrlr/usercontrol.cxx:214: OFormattedNumericControl::SetFormatDescription: invalid format key! warn:legacy.tools:59591:59591:extensions/source/propctrlr/usercontrol.cxx:214: OFormattedNumericControl::SetFormatDescription: invalid format key! warn:legacy.tools:59591:59591:extensions/source/propctrlr/usercontrol.cxx:214: OFormattedNumericControl::SetFormatDescription: invalid format key! warn:legacy.osl:59591:59591:extensions/source/propctrlr/usercontrol.cxx:98: OFormatSampleControl::setValue: invalid format entry! warn:legacy.tools:59591:59591:extensions/source/propctrlr/usercontrol.cxx:141: OFormattedNumericControl::SetFormatDescription: invalid format key! Interestingly, I don't reproduce this with gen rendering. (export SAL_USE_VCLPLUGIN=gen;soffice --writer) Robert: what's rendering do you use? gtk3, qt? other ? Do you confirm you don't reproduce either with gen rendering? Caolán: thought you might be interested in this one since it seems related to vcl rendering more than extensions part. (In reply to Julien Nabet from comment #2) > Interestingly, I don't reproduce this with gen rendering. > (export SAL_USE_VCLPLUGIN=gen;soffice --writer) > > Robert: what's rendering do you use? gtk3, qt? other ? Do you confirm you > don't reproduce either with gen rendering? This works with VCL kf5. The field will be formatted right. The chosen format will be set and if I change back to the formatting it will switch to "Date", not to "Decimal". General → Formatting shows it wrong. It will always show 05/18/1927 (or something like this in your language.) Thought this would be the same bug, but it isn't. Bibisected to the following commit using repo bibisect-linux-64-7.0. https://cgit.freedesktop.org/libreoffice/core/commit/?id=1efeb17837c22499f00299c033ae59ba3910f7d7 author Caolán McNamara <caolanm@redhat.com> 2019-11-04 13:06:04 +0000 committer Caolán McNamara <caolanm@redhat.com> 2019-12-09 13:28:35 +0100 weld Property Browser Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/c4b1578006473c76302453eae80a1f5d473c1191 Related: tdf#138661 don't limit OFormatSampleControl to +10000 It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/56fba55533ed5a555e7ef184c4399e6497b22315 Related: tdf#138661 don't limit OFormatSampleControl to +10000 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8b3982681e98818388c09233960ad6eaacee205a tdf#138661 don't emit value-changed when not changed by user It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. fixed in master and 7-1, backport to 7-0 in gerrit Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/8a6d2cbbec5d3b779bba9003b482c47a3a1d38c2 tdf#138661 don't emit value-changed when not changed by user It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in Version: 7.2.0.0.alpha0+ Build ID: 4484accf4d331a95ebf8475d6cd91950f4c27bcc CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, thanks for fixing this issue!! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/5fbd913cf62aa215c66f1f2de47723dc82c83571 tdf#138661 don't emit value-changed when not changed by user It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |