| Summary: | Introduce "reset crop" command | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Telesto <telesto> |
| Component: | UI | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | enhancement | CC: | dbarkleyyeung, heiko.tietze, mentoring, stephane.guillou |
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | Example file | ||
|
Description
Telesto
2020-12-11 08:39:50 UTC
Created attachment 168043 [details]
Example file
I would agree that a reset-button inside the crop tap would be convenient. But an extra menu-entry under Format > Image and the image context menu would just clutter the UI. (In reply to Sascha Z from comment #2) > I would agree that a reset-button inside the crop tap would be convenient. > But an extra menu-entry under Format > Image and the image context menu > would just clutter the UI. I personally find easier to have it right click context menu (because it's by far more comfortable to use.. Obviously only in cases where crop being actually applied. It's worth the clutter The alternative compromise would be to make it accessible from modify.. however not sure if there is a possibility for context depend menu items Let's realize the uncrop function, add a button to the dialog and a UNO command for customization. I tend to agree with Telesto that uncrop inn the context menu is desirable - but please only if crop has been applied. The dialog is cui/uiconfig/ui/croppage.ui, for code inspiration search for SID_ATTR_GRAF_CROP (In reply to Heiko Tietze from comment #4) > Let's realize the uncrop function, add a button to the dialog and a UNO > command for customization. I tend to agree with Telesto that uncrop inn the > context menu is desirable - but please only if crop has been applied. > > The dialog is cui/uiconfig/ui/croppage.ui, for code inspiration search for > SID_ATTR_GRAF_CROP Small note: the desire for 'reset crop' mostly vanishes at the point writer is getting the draw/impress crop. Where you actually can see the full image (in the case if it's cropped already) The writer implementation kind of bad in that perspective.. So the necessity for "reset crop" kind of vanishes with the 'impress/draw' crop which will come to writer eventually. So this is more an ad interim suggestion in the first place. If it's still needed after the move is made.. open for debate IMHO. In a way off-topic Nuance to my previous comment. Somehow it's possible to increase the image with crop in Impress/Draw.. So crop handles can go outside the actual dimensions of the image.. In this stage it would even make sense in Draw/Impress to have reset crop (which kind of awful work around) but not sure if this way on purpose.. @Heiko Any knowledge I will try to add a context menu command. I'm not sure what to do about zoom mode aka Keep image size radio button. If user has cropped in this mode, the scale has changed. Should I reset the scale? If so, does the program still know what the original scale was? Is there anywhere else that can edit the scale? Is it going to be surprising that the reset crop button also resets the scale? Please don't change the status to needinfo, it is not the thing to do in this case: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO I would like to work on this. Re-evaluating the EasyHack in 2022 This enhancement is still relevant. As per comment 2 and comment 3, I think it would be good to have "Reset Crop" both in the dialog and right click context menu. |