| Summary: | FILEOPEN DOCX Empty paragraph after two consecutive breaks gets numbering | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | NISZ LibreOffice Team <libreoffice> |
| Component: | Writer | Assignee: | Justin L <jluth> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | jluth, nemeth, xiscofauli |
| Priority: | medium | Keywords: | bibisected, bisected, filter:docx, regression |
| Version: | 6.1.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=105134 https://bugs.documentfoundation.org/show_bug.cgi?id=95377 |
||
| Whiteboard: | target:7.2.0 target:7.1.0.0.beta2 target:7.0.5 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 130447 | ||
| Attachments: |
Example file from Word
Screenshot of the original document side by side in Word and Writer |
||
|
Description
NISZ LibreOffice Team
2020-12-14 11:44:40 UTC
Created attachment 168146 [details]
Screenshot of the original document side by side in Word and Writer
Reproduced in Version: 7.1.0.0.alpha1+ Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded OK - this is what I think was happening. BEFORE: It gets to pStyle assignment of List Paragraph. Assigns PROP_NUMBERING_RULES. Then gets to the end of the paragraph and bRemove/bNoNumbering. NoNumbering removes the applied PROP_NUMBERING_RULE, and then finishParagraph was called - which did nothing about numbering at that time. NOW: pStyle waits until finishParagraph to apply numbering. bNoNumbering removes directly applied PROP_NUMBERING_RULE, and then finishParagraph is called, and it applies the list numbering. Surprisingly, there are no unit tests that hit this behaviour. This situation just got harder with "Since LO7.0/tdf#131321 fixed the loss of numbering in styles, this OUGHT to be obsolete,". So this requires ADDING a cancelling numbering rule in case the style assigns one. Proposed fix at http://gerrit.libreoffice.org/c/core/+/107738 Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bfcd952dc7820c4cf8761c4222d29ede039391dc tdf#138892 writerfilter: cancel style list if bNoNumbering It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/e901ffcb93d217f2cc09021a3b2fecb36f9884f6 tdf#138892 writerfilter: cancel style list if bNoNumbering It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/88aa8f5343705008b86ef41512993a00d331a668 tdf#138892 writerfilter: cancel style list if bNoNumbering It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified in: Version: 7.2.0.0.alpha0+ (x64) Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-GB Calc: threaded Thanks for fixing! |