| Summary: | Confusion on password with period character | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | lenainjaune <lnj.sam> |
| Component: | LibreOffice | Assignee: | Mike Kaganski <mikekaganski> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | caolan.mcnamara |
| Priority: | medium | ||
| Version: | Inherited From OOo | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bz.apache.org/ooo/show_bug.cgi?id=1820 | ||
| Whiteboard: | target:7.2.0 | ||
| Crash report or crash signature: | Regression By: | ||
|
Description
lenainjaune
2020-12-15 10:06:05 UTC
IMO this makes sense. Caolan, do you know if we may somehow handle keyboard input differently in password fields wrt org.openoffice.Setup/L10N/DecimalSeparatorAsLocale? Code pointer: In vcl/source/window/winproc.cxx, ImplHandleKey tests if nEvCode == KEY_DECIMAL, and then behaves according to Application::GetSettings().GetMiscSettings().GetEnableLocalizedDecimalSep(). But I don't know how to check if that's a password box: pWindow points to dialog window, it seems. So here is the proposed patch: https://gerrit.libreoffice.org/c/core/+/107751 yikes, that's a hilarious gotcha. Proposed patch looks reasonable under the circumstances Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/86de82ae54a243743b3775d44281dd02fcad6014 tdf#138932: don't modify KEY_DECIMAL for password box It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/491efa1e5513f9c7901849dfb2c72e379efc91bd tdf#138932 don't replace . with , for gtk password GtkEntries too It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |